Skip to content

Implementation of OB FPC Capacitors - #15652

Open
mario6829 wants to merge 2 commits into
AliceO2Group:devfrom
mario6829:itsgeo
Open

Implementation of OB FPC Capacitors#15652
mario6829 wants to merge 2 commits into
AliceO2Group:devfrom
mario6829:itsgeo

Conversation

@mario6829

@mario6829 mario6829 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

The capacitors on the OB FPC have been implemented. Dimensions and positions were obtained from Gerber files and direct information from experts. It has been verified that the sensor position hasn't changed after the implementation.

@alibuild alibuild mentioned this pull request Jul 30, 2026
Closed
f3sch
f3sch approved these changes Jul 30, 2026
View reviewed changes

@f3sch f3sch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I guess we are effectively not using the mBuildLevel otherwise for buildLevel >= 5 the ypos would not be modified and the capacitors are placed ~150 um below their nominal position?

P.S. Did you check the potentially floating capacitors, I pointed out a while ago (maybe I was also wrong)?

@mario6829

mario6829 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Hi @f3sch indeed in normal run mBuildLevel is always equal to 0. It is (well, actually was) used only for material budget studies, in order to determine the contribution of each material by selectively taking them out. So under any normal execution it has no effect. Nevertheless I acknowledge that the logic was corrected before, but now it can be improved. I'll fix it in the next release.
The check on the potentially floating capacitors is the very next task in my to-do list. I'll come back shortly with a result (either a negative check or a code fix). Thanks for pointing it out.
Best

@alibuild

alibuild commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 347faeb at 2026-08-04 07:00:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/ff07ae4d6190b4a3bdad684e6560c2e864126b16/slc9_x86-64/o2checkcode/1.0-local351/etc/modulefiles
++ alibuild-generate-module
+ HAS_BIN=
+ HAS_LIB=
+ HAS_CMAKE=
+ HAS_ROOT=
+ '[' 0 '!=' 0 ']'
+ cat
+ printf 'if ![ is-loaded '\''BASE/1.0'\'' ] {\n module load BASE/1.0\n}'
+ echo 'BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release'
BUILD_REQUIRES=CMake alibuild-recipe-tools defaults-release
+ FULL_BUILD_REQUIRES='bz2 pytorch_cpuinfo date ninja MPFR defaults-release googlebenchmark UUID Alice-GRID-Utils CMake FairCMakeModules O2-customization ninja-fortran json-c safe_int alibuild-recipe-tools double-conversion Python-modules-list'
+ echo 'FULL_BUILD_REQUIRES=bz2 pytorch_cpuinfo date ninja MPFR defaults-release googlebenchmark UUID Alice-GRID-Utils CMake FairCMakeModules O2-customization ninja-fortran json-c safe_int alibuild-recipe-tools double-conversion Python-modules-list'
FULL_BUILD_REQUIRES=bz2 pytorch_cpuinfo date ninja MPFR defaults-release googlebenchmark UUID Alice-GRID-Utils CMake FairCMakeModules O2-customization ninja-fortran json-c safe_int alibuild-recipe-tools double-conversion Python-modules-list
++ env
++ cut -f1 -d=
++ grep -v '^DEFAULT_'
++ grep -v PKGREVISION
++ grep -v ALIBUILD_RECIPE_TOOLS
++ grep REVISION
++ sed -e s/_REVISION//
+ for x in $(env | cut -f1 -d= | grep -v "^DEFAULT_" | grep -v PKGREVISION | grep -v ALIBUILD_RECIPE_TOOLS | grep REVISION | sed -e 's/_REVISION//')
++ eval 'echo $LIBFFI_REVISION'
+++ echo 10
+ REVISION_VALUE=10
++ eval 'echo $LIBFFI_VERSION'
+++ echo v3.2.1-alice1
+ VERSION_VALUE=v3.2.1-alice1
++ eval 'echo $LIBFFI_ROOT'
+++ echo /sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ ROOT_PATH_VALUE=/sw/slc9_x86-64/libffi/v3.2.1-alice1-10
+ '[' -z 10 ']'
+ echo 'bz2 pytorch_cpuinfo date ninja MPFR defaults-release googlebenchmark UUID Alice-GRID-Utils CMake FairCMakeModules O2-customization ninja-fortran json-c safe_int alibuild-recipe-tools double-conversion Python-modules-list'
+ tr '[:lower:]' '[:upper:]'
+ tr - _
+ tr ' ' '\n'
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@f3sch f3sch f3sch approved these changes
@fprino fprino Awaiting requested review from fprino fprino is a code owner
@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner
@mconcas mconcas Awaiting requested review from mconcas mconcas is a code owner
@shahor02 shahor02 Awaiting requested review from shahor02 shahor02 is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mario6829 @alibuild @f3sch