Address review: test names, length cases, previousPasswords

Author: salahalsabhi

sprint-3-stretch-exercises/card-validator.test.js

@@ -1,25 +1,33 @@
 import { isValidCardNumber } from "./card-validator.js";
 
-test("accepts a valid card number", () => {
+test("should accept a valid 16-digit card number", () => {
   expect(isValidCardNumber("9999777788880000")).toEqual(true);
 });
 
-test("accepts another valid card number", () => {
+test("should accept another valid 16-digit card number", () => {
   expect(isValidCardNumber("6666666666661666")).toEqual(true);
 });
 
-test("rejects non-digit characters", () => {
+test("should reject a card number with non-digit characters", () => {
   expect(isValidCardNumber("a92332119c011112")).toEqual(false);
 });
 
-test("rejects all same digits", () => {
+test("should reject a card number where all digits are the same", () => {
   expect(isValidCardNumber("4444444444444444")).toEqual(false);
 });
 
-test("rejects sum of 16 or less", () => {
+test("should reject a card number whose digits sum to 16 or less", () => {
   expect(isValidCardNumber("1111111111111110")).toEqual(false);
 });
 
-test("rejects odd final digit", () => {
+test("should reject a card number with an odd final digit", () => {
   expect(isValidCardNumber("6666666666666661")).toEqual(false);
 });
+
+test("should reject a card number shorter than 16 digits", () => {
+  expect(isValidCardNumber("123456789012345")).toEqual(false);
+});
+
+test("should reject a card number longer than 16 digits", () => {
+  expect(isValidCardNumber("12345678901234567")).toEqual(false);
+});

sprint-3-stretch-exercises/password-validator.js

@@ -1,16 +1,19 @@
-const previousPasswords = ["password", "12345", "qwerty"];
+const defaultPreviousPasswords = ["password", "12345", "qwerty"];
 
-export function isValidPassword(password) {
+export function isValidPassword(
+  password,
+  previousPasswords = defaultPreviousPasswords
+) {
   if (password.length < 5) {
     return false;
   }
 
-  const upperCase = /[A-Z]/.test(password);
-  const lowerCase = /[a-z]/.test(password);
-  const number = /[0-9]/.test(password);
-  const symbol = /[!#$%.*&]/.test(password);
+  const hasUpper = /[A-Z]/.test(password);
+  const hasLower = /[a-z]/.test(password);
+  const hasDigit = /[0-9]/.test(password);
+  const hasSymbol = /[!#$%.*&]/.test(password);
 
-  if (!upperCase || !lowerCase || !number || !symbol) {
+  if (!hasUpper || !hasLower || !hasDigit || !hasSymbol) {
     return false;
   }
 

sprint-3-stretch-exercises/password-validator.test.js

@@ -16,32 +16,36 @@ You must breakdown this problem in order to solve it. Find one test case first a
 */
 import { isValidPassword } from "./password-validator.js";
 
-test("password has at least 5 characters and meets all rules", () => {
+test("password should have at least 5 characters and meets all rules", () => {
   const password = "Abc1!";
   const result = isValidPassword(password);
   expect(result).toEqual(true);
 });
 
-test("rejects password shorter than 5 characters", () => {
+test("should rejects password shorter than 5 characters", () => {
   expect(isValidPassword("Ab1!")).toEqual(false);
 });
 
-test("rejects password without uppercase", () => {
+test("should rejects password without uppercase", () => {
   expect(isValidPassword("abc1!")).toEqual(false);
 });
 
-test("rejects password without lowercase", () => {
+test("should rejects password without lowercase", () => {
   expect(isValidPassword("ABC1!")).toEqual(false);
 });
 
-test("rejects password without number", () => {
+test("should rejects password without number", () => {
   expect(isValidPassword("Abcde!")).toEqual(false);
 });
 
-test("rejects password without symbol", () => {
+test("should rejects password without symbol", () => {
   expect(isValidPassword("Abc12")).toEqual(false);
 });
 
-test("rejects previous password", () => {
+test("should rejects previous password", () => {
   expect(isValidPassword("password")).toEqual(false);
 });
+
+test("should reject a password listed in the previousPasswords argument", () => {
+  expect(isValidPassword("Abc1!", ["Abc1!"])).toEqual(false);
+});