London | 26-ITP-May | Sayeed Hussain | Sprint 3 | implement-and-rewrite - #1590
Open
sayeedhussain01 wants to merge 28 commits into
Open
London | 26-ITP-May | Sayeed Hussain | Sprint 3 | implement-and-rewrite#1590sayeedhussain01 wants to merge 28 commits into
sayeedhussain01 wants to merge 28 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
sayeedhussain01
added
📅 Sprint 3
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Aug 1, 2026
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good work, just one suggestion for an improvement
|
|
||
| function isProperFraction(numerator, denominator) { | ||
| // TODO: Implement this function | ||
| let fraction = Math.abs(numerator) < Math.abs(denominator); |
There was a problem hiding this comment.
This works, good use of Abs, but can the return statement be simplified?
LonMcGregor
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
I have completed all tasks.