fix: address PR review feedback (doctest fixes, edge case handling, formatting)

Author: BABTUNA

src/daft-functions-temporal/src/date_construction.rs

@@ -151,7 +151,12 @@ impl ScalarUDF for MakeTimestamp {
             .map(|(((((y, mo), d), h), mi), s)| match (y, mo, d, h, mi, s) {
                 (Some(y), Some(mo), Some(d), Some(h), Some(mi), Some(s)) => {
                     let whole_secs = s as u32;
-                    let frac_micros = ((s - whole_secs as f64) * 1_000_000.0).round() as u32;
+                    let frac_micros_raw = ((s - whole_secs as f64) * 1_000_000.0).round() as u32;
+                    let (whole_secs, frac_micros) = if frac_micros_raw >= 1_000_000 {
+                        (whole_secs + 1, 0)
+                    } else {
+                        (whole_secs, frac_micros_raw)
+                    };
                     let date = NaiveDate::from_ymd_opt(y, mo as u32, d as u32)?;
                     let time = chrono::NaiveTime::from_hms_micro_opt(
                         h as u32,
@@ -306,7 +311,12 @@ impl ScalarUDF for MakeTimestampLtz {
             .map(|(((((y, mo), d), h), mi), s)| match (y, mo, d, h, mi, s) {
                 (Some(y), Some(mo), Some(d), Some(h), Some(mi), Some(s)) => {
                     let whole_secs = s as u32;
-                    let frac_micros = ((s - whole_secs as f64) * 1_000_000.0).round() as u32;
+                    let frac_micros_raw = ((s - whole_secs as f64) * 1_000_000.0).round() as u32;
+                    let (whole_secs, frac_micros) = if frac_micros_raw >= 1_000_000 {
+                        (whole_secs + 1, 0)
+                    } else {
+                        (whole_secs, frac_micros_raw)
+                    };
                     let date = NaiveDate::from_ymd_opt(y, mo as u32, d as u32)?;
                     let time = chrono::NaiveTime::from_hms_micro_opt(
                         h as u32,

src/daft-functions-temporal/src/date_navigation.rs

@@ -42,17 +42,16 @@ impl ScalarUDF for LastDay {
         let values: Vec<Option<i32>> = arr
             .iter()
             .map(|opt_days| {
-                opt_days.map(|days| {
+                opt_days.and_then(|days| {
                     let d = days_to_date(days);
                     let (y, m) = (d.year(), d.month());
-                    let last = if m == 12 {
+                    let first_of_next = if m == 12 {
                         NaiveDate::from_ymd_opt(y + 1, 1, 1)
                     } else {
                         NaiveDate::from_ymd_opt(y, m + 1, 1)
-                    }
-                    .unwrap()
-                        - chrono::Duration::days(1);
-                    date_to_days(last)
+                    }?;
+                    let last = first_of_next - chrono::Duration::days(1);
+                    Some(date_to_days(last))
                 })
             })
             .collect();

src/daft-functions-temporal/src/lib.rs

@@ -11,8 +11,6 @@ mod unix_timestamp;
 
 use common_error::{DaftResult, ensure};
 use current::{CurrentDate, CurrentTimestamp, CurrentTimezone};
-use date_construction::{MakeDate, MakeTimestamp, MakeTimestampLtz};
-use date_navigation::{LastDay, NextDay};
 use daft_core::{
     prelude::{DataType, Field, Schema},
     series::Series,
@@ -22,6 +20,8 @@ use daft_dsl::{
     functions::{FunctionArgs, FunctionModule, FunctionRegistry, ScalarUDF, UnaryArg},
 };
 use date_arithmetic::{DateAdd, DateDiff, DateSub};
+use date_construction::{MakeDate, MakeTimestamp, MakeTimestampLtz};
+use date_navigation::{LastDay, NextDay};
 use epoch_conversions::{
     DateFromUnixDate, FromUnixtime, TimestampMicros, TimestampMillis, TimestampSeconds,
 };