Skip to content

Commit 74f2b3c

Browse files
bveredtyichye19alonfirestein
authored
Release 1.4.0 (#81)
* bump version to 1.4.0 (#65) * bump version to 1.4.0 * revert documentation changes * update operator tag --------- Signed-off-by: 662962756 <bvered@il.ibm.com> * Docs md transforms (#67) * md transform * adding support matrix * reformatting of summary.md * updated support summary linking * format updates * changed DITA source files to MD * Task/remove dita files (#68) * delete dita files * update release date Signed-off-by: 662962756 <bvered@il.ibm.com> * replace build with buildx and add more makefile variable (#70) Signed-off-by: Tal Yichye <tal.yichye@ibm.com> * update RESOURCES_NAMESPACE (#71) * update RESOURCES_NAMESPACE * update operator tag to latest 1.4.0 Signed-off-by: 662962756 <bvered@il.ibm.com> * update github action to supported workflows (#73) Signed-off-by: 662962756 <bvered@il.ibm.com> * enable github actions (#74) Signed-off-by: 662962756 <bvered@il.ibm.com> * update operator branch Signed-off-by: 662962756 <bvered@il.ibm.com> * update docs files Signed-off-by: 662962756 <bvered@il.ibm.com> * update what's new in 1.4.0 Signed-off-by: 662962756 <bvered@il.ibm.com> * update what's new in 1.4.0 Signed-off-by: 662962756 <bvered@il.ibm.com> * update odf matrix Signed-off-by: 662962756 <bvered@il.ibm.com> * update odf matrix Signed-off-by: 662962756 <bvered@il.ibm.com> * update odf matrix Signed-off-by: 662962756 <bvered@il.ibm.com> * Task/odf 410 update docs (#77) * update what's new in 1.4.0 * update odf matrix Signed-off-by: 662962756 <bvered@il.ibm.com> * add known issues page Signed-off-by: 662962756 <bvered@il.ibm.com> * add known issues page Signed-off-by: 662962756 <bvered@il.ibm.com> * add known issues page Signed-off-by: 662962756 <bvered@il.ibm.com> * add known issues page Signed-off-by: 662962756 <bvered@il.ibm.com> * add known issues page Signed-off-by: 662962756 <bvered@il.ibm.com> * add storage-system-in-progressing.png Signed-off-by: 662962756 <bvered@il.ibm.com> * add storage-system-in-progressing.png Signed-off-by: 662962756 <bvered@il.ibm.com> * add storage-system-in-progressing.png Signed-off-by: 662962756 <bvered@il.ibm.com> * add storage-system-in-progressing.png Signed-off-by: 662962756 <bvered@il.ibm.com> * add storage-system-in-progressing.png Signed-off-by: 662962756 <bvered@il.ibm.com> * add storage-system-in-progressing.png Signed-off-by: 662962756 <bvered@il.ibm.com> * updte known-issues Signed-off-by: 662962756 <bvered@il.ibm.com> * update known-issues Signed-off-by: 662962756 <bvered@il.ibm.com> * update known-issues Signed-off-by: 662962756 <bvered@il.ibm.com> * update known-issues Signed-off-by: 662962756 <bvered@il.ibm.com> * fix documentation after Hatsav review (#79) Signed-off-by: 662962756 <bvered@il.ibm.com> * update operator tag Signed-off-by: 662962756 <bvered@il.ibm.com> --------- Signed-off-by: 662962756 <bvered@il.ibm.com> Signed-off-by: Tal Yichye <tal.yichye@ibm.com> Co-authored-by: tyichye19 <84450119+tyichye19@users.noreply.github.com> Co-authored-by: Alon Firestein <57404551+alonfirestein@users.noreply.github.com>
1 parent 754a1c3 commit 74f2b3c

26 files changed

+239
-279
lines changed

‎.github/workflows/codespell.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- uses: actions/checkout@v2
1515

1616
- name: codespell
17-
uses: codespell-project/actions-codespell@master
17+
uses: codespell-project/actions-codespell@v1
1818
with:
1919
check_filenames: true
2020
check_hidden: true

‎.github/workflows/iso-ci.yaml‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,11 @@ jobs:
5555

5656
- name: get tag without v
5757
id: tag
58+
shell: bash
5859
if: ${{ github.event_name == 'release' && github.event.action == 'published' }}
59-
uses: battila7/get-version-action@v2
60+
run: |
61+
BUILD_VERSION=${{ github.event.release.tag_name }}
62+
echo "BUILD_VERSION=${BUILD_VERSION:1}" >> $GITHUB_ENV
6063
6164
# Build and (optionally) push the driver image
6265
- name: build the driver image
@@ -68,4 +71,4 @@ jobs:
6871
# Only push if we are publishing a release
6972
push: ${{ github.event_name == 'release' && github.event.action == 'published' }}
7073
# Use a 'dev' tag, that won't be pushed, for non-release builds
71-
tags: quay.io/ibmodffs/ibm-storage-odf-block-driver:${{ steps.tag.outputs.version-without-v || 'dev' }}
74+
tags: quay.io/ibmodffs/ibm-storage-odf-block-driver:${{ env.BUILD_VERSION || 'dev' }}

‎Dockerfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ LABEL vendor="IBM" \
2020
org.label-schema.vendor="IBM" \
2121
org.label-schema.name="ibm storage odf driver" \
2222
org.label-schema.vcs-url="https://github.com/IBM/ibm-storage-odf-block-driver" \
23-
org.label-schema.schema-version="1.3.0"
23+
org.label-schema.schema-version="1.4.0"
2424

2525
WORKDIR /
2626

‎Makefile‎

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
11

22
LINT_VERSION="1.40.0"
33

4-
IMAGE_REPO="quay.io"
5-
NAME_SPACE="ibmodffs"
6-
DRIVER_IMAGE_VERSION=1.3.0
7-
4+
REGISTRY=quay.io/ibmodffs
5+
IMAGE_TAG=1.4.0
6+
PLATFORM=linux/amd64,linux/ppc64le,linux/s390x
87
DRIVER_NAME=ibm-storage-odf-block-driver
98

10-
DRIVER_IMAGE=$(IMAGE_REPO)/${NAME_SPACE}/$(DRIVER_NAME)
9+
DRIVER_IMAGE=$(REGISTRY)/$(DRIVER_NAME):$(IMAGE_TAG)
10+
BUILD_COMMAND = docker buildx build -t $(DRIVER_IMAGE) --platform $(PLATFORM) -f ./Dockerfile .
11+
1112

12-
.PHONY: all $(DRIVER_IMAGE)
13+
.PHONY: all $(DRIVER_NAME)
1314

14-
all: $(DRIVER_IMAGE)
15+
all: $(DRIVER_NAME)
1516

16-
$(DRIVER_IMAGE):
17+
$(DRIVER_NAME):
1718
if [ ! -d ./vendor ]; then dep ensure -v; fi
1819
CGO_ENABLED=0 GOOS=linux GO111MODULE=on go build -ldflags '-extldflags "-static"' -o ./build/_output/bin/${DRIVER_NAME} ./cmd/manager/main.go
1920

@@ -28,7 +29,7 @@ lint: deps
2829
golangci-lint run -E gosec --timeout=6m # Run `make lint-fix` may help to fix lint issues.
2930

3031
.PHONY: lint-fix
31-
lint-fix: deps
32+
lint-fix: deps
3233
golangci-lint run --fix
3334

3435
.PHONY: build
@@ -38,12 +39,12 @@ build:
3839
.PHONY: test
3940
test:
4041
go test -race -covermode=atomic -coverprofile=cover.out ./pkg/...
41-
42-
build-image:
43-
docker build -t $(DRIVER_IMAGE):$(DRIVER_IMAGE_VERSION) -f ./Dockerfile .
4442

45-
push-image: build-image
46-
docker push $(DRIVER_IMAGE):$(DRIVER_IMAGE_VERSION)
43+
build-image:
44+
$(BUILD_COMMAND)
45+
46+
push-image:
47+
$(BUILD_COMMAND) --push
4748

4849
clean: bin-clean
4950

@@ -54,4 +55,4 @@ add-copyright:
5455
hack/add-copyright.sh
5556

5657
check-copyright:
57-
hack/check-copyright.sh
58+
hack/check-copyright.sh

‎cmd/manager/main.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ import (
3131
)
3232

3333
const (
34-
EnvNamespaceName = "WATCH_NAMESPACE"
34+
EnvNamespaceName = "RESOURCES_NAMESPACE"
3535
)
3636

3737
func init() {

‎docs/SUMMARY.md‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Table of Contents
2+
3+
* [ODF FlashSystem driver welcome](docs_general/docs_welcome.md)
4+
* [ODF FlashSystem driver support summary](docs_general/odf_flashsystem_driver_support_matrix.md)
5+
* [What's new](docs_general/docs_whatsnew.md)
6+
* [Trademarks](docs_general/trademarks.md)
7+
* [Installing the driver](installing/installing.md)
8+
* [Configuring](configuring/configuring.md)
9+
* [Limitations](configuring/limitations.md)
10+
* [Known Issues](configuring/known_issues.md)
11+
* [Related information and publications](docs_general/relatedpubs.md)

‎docs/configuring/configuring.dita‎

Lines changed: 0 additions & 47 deletions
This file was deleted.

‎docs/configuring/configuring.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Configuring
2+
3+
Red Hat® OpenShift® Data Foundation (ODF) uses the ODF FlashSystem driver to integrate with your IBM FlashSystem® storage system. When using the OpenShift Data Foundation with your storage system ensure that all configuration needs are met by following the Red Hat ODF documentation set.
4+
5+
The ODF FlashSystem driver enable IBM Spectrum Virtualize family products to be used with Red Hat OpenShift Data Foundation.
6+
7+
For more information and documentation, see the following:
8+
9+
- Support summary for enabled IBM Spectrum Virtualize family products and Red Hat OpenShift Data Foundation: [ODF FlashSystem driver support summary](../landing/odf_flashsystem_driver_support_matrix.html).
10+
- User information and release notes documentation for the Red Hat OpenShift Data Foundation: [OpenShift Data Foundation documentation](https://access.redhat.com/documentation/en-us/red_hat_openshift_data_foundation).
11+
- General information about the OpenShift Data Foundation, a software-defined storage for containers: [OpenShift Data Foundation](https://www.redhat.com/en/technologies/cloud-computing/openshift-data-foundation).
12+
13+
## Configuration considerations
14+
15+
When creating block storage persistent volumes, be sure to select the storage class <storage_class_name> for best performance. The storage class allows a direct I/O path to the FlashSystem storage system.
16+
17+

‎docs/configuring/known_issues.md‎

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
# Known issues
2+
3+
### Storage system status stuck on 'Progressing'
4+
##### Problem:
5+
In some specific circumstances, after adding FlashSystem as external storage, some Flash storage systems might get stuck on 'Progressing' state due to a status sync delay on RedHat ODF operator.
6+
##### Detected in version:
7+
ODF 4.13 using ODF-FS 1.4.0
8+
##### Problem verification:
9+
On Openshift Console go to Storage -> Data Foundation -> storage systems. Some storage systems might be stuck forever with a status of: "Progressing" and never changes to "Available".
10+
11+
![Storage-system-in-progressing-github3](storage-system-in-progressing2.png "storage-system")
12+
##### Workaround:
13+
1. SSH into OCP cluster
14+
2. Switch to openshift-storage namespace by running: <br>
15+
$ oc project openshift-storage
16+
3. Find odf-controller-manager pod by running: <br>
17+
$ oc get pods | grep odf-operator-controller-manager
18+
4. Delete the pod found in the previous step by running: <br>
19+
$ oc delete pod {odf-operator-controller-manager-*}
20+
5. The pod will be recreated automatically, verify pod creation by running: <br>
21+
$ oc get pods | grep odf-operator-controller-manager
22+
6. Storage system status should change to 'Available' after a few minutes
23+
24+
25+
##### Links:
26+
https://bugzilla.redhat.com/show_bug.cgi?id=2207619 <br>
27+
https://jira.xiv.ibm.com/browse/ODF-448
28+

‎docs/configuring/limitations.dita‎

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)