✍️ Issue Description
IterableEmbeddedManager.handleEmbeddedClick has unnecessary parameters. Both message: IterableEmbeddedMessage and buttonIdentifier: String? are not used inside the method. There is also no documentation what the parameters are for. The method does nothing when clickedUrl is null. This makes the method annoying to use, as behavior is not immediately clear and I have to do extra work to provide parameters that won't even be used.
📋 Steps to Reproduce
- check the code of
IterableEmbeddedManager.handleEmbeddedClick
Suggested improvement
- add a new method
handleEmbeddedClick(clickedUrl: String)
- deprecate the old method
handleEmbeddedClick(message: IterableEmbeddedMessage, buttonIdentifier: String?, clickedUrl: String?)
- add KDoc to the whole class to make it easier to use
Iterable Android SDK 3.6.3
✍️ Issue Description
IterableEmbeddedManager.handleEmbeddedClickhas unnecessary parameters. Bothmessage: IterableEmbeddedMessageandbuttonIdentifier: String?are not used inside the method. There is also no documentation what the parameters are for. The method does nothing whenclickedUrlis null. This makes the method annoying to use, as behavior is not immediately clear and I have to do extra work to provide parameters that won't even be used.📋 Steps to Reproduce
IterableEmbeddedManager.handleEmbeddedClickSuggested improvement
handleEmbeddedClick(clickedUrl: String)handleEmbeddedClick(message: IterableEmbeddedMessage, buttonIdentifier: String?, clickedUrl: String?)Iterable Android SDK 3.6.3