From 87ef6b1f85ded6992af8e0be7d7a9ca0aa5dcb1f Mon Sep 17 00:00:00 2001
From: Rolf39 <ahmedrolf39@gmail.com>
Date: Sun, 13 Sep 2026 03:17:35 +0200
Subject: [PATCH] fix(service): update SignFileService to use
 IPkcs12SignEngineHandler

Signed-off-by: Rolf39 <ahmedrolf39@gmail.com>
---
 .../SignEngine/IPkcs12SignEngineHandler.php    | 18 ++++++++++++++++++
 lib/Handler/SignEngine/ISignEngineHandler.php  |  5 -----
 lib/Handler/SignEngine/SignEngineHandler.php   |  2 +-
 lib/Service/SignFileService.php                |  3 ++-
 4 files changed, 21 insertions(+), 7 deletions(-)
 create mode 100644 lib/Handler/SignEngine/IPkcs12SignEngineHandler.php

diff --git a/lib/Handler/SignEngine/IPkcs12SignEngineHandler.php b/lib/Handler/SignEngine/IPkcs12SignEngineHandler.php
new file mode 100644
index 0000000000..f1becc472a
--- /dev/null
+++ b/lib/Handler/SignEngine/IPkcs12SignEngineHandler.php
@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: Copyright (c) 2026 Rolf39
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+namespace OCA\Libresign\Handler\SignEngine;
+
+interface IPkcs12SignEngineHandler extends ISignEngineHandler {
+	public function setCertificate(string $certificate): self;
+	public function getCertificate(): string;
+	public function readCertificate(): array;
+	public function setPassword(string $password): self;
+	public function getPassword(): string;
+}
diff --git a/lib/Handler/SignEngine/ISignEngineHandler.php b/lib/Handler/SignEngine/ISignEngineHandler.php
index fecd98fb03..83534967b0 100644
--- a/lib/Handler/SignEngine/ISignEngineHandler.php
+++ b/lib/Handler/SignEngine/ISignEngineHandler.php
@@ -13,11 +13,6 @@
 interface ISignEngineHandler {
 	public function setInputFile(File $inputFile): self;
 	public function getInputFile(): File;
-	public function setCertificate(string $certificate): self;
-	public function getCertificate(): string;
-	public function readCertificate(): array;
-	public function setPassword(string $password): self;
-	public function getPassword(): string;
 	public function sign(): File;
 	public function getSignedContent(): string;
 	public function getSignatureParams(): array;
diff --git a/lib/Handler/SignEngine/SignEngineHandler.php b/lib/Handler/SignEngine/SignEngineHandler.php
index 4c5d6d4883..1b1ac4c28c 100644
--- a/lib/Handler/SignEngine/SignEngineHandler.php
+++ b/lib/Handler/SignEngine/SignEngineHandler.php
@@ -24,7 +24,7 @@
 use OCP\IL10N;
 use Psr\Log\LoggerInterface;
 
-abstract class SignEngineHandler implements ISignEngineHandler {
+abstract class SignEngineHandler implements IPkcs12SignEngineHandler {
 	private File $inputFile;
 	protected string $certificate = '';
 	private string $pfxFilename = 'signature.pfx';
diff --git a/lib/Service/SignFileService.php b/lib/Service/SignFileService.php
index 6f5a144bce..95f61e47cf 100644
--- a/lib/Service/SignFileService.php
+++ b/lib/Service/SignFileService.php
@@ -36,6 +36,7 @@
 use OCA\Libresign\Handler\PdfTk\Pdf;
 use OCA\Libresign\Handler\SignEngine\ISignEngineHandler;
 use OCA\Libresign\Handler\SignEngine\Pkcs12Handler;
+use OCP\Libresign\Handler\SignEngine\IPkcs12SignEngineHandler;
 use OCA\Libresign\Handler\SignEngine\SignEngineFactory;
 use OCA\Libresign\Handler\SignEngine\SignEngineHandler;
 use OCA\Libresign\Helper\JSActions;
@@ -85,7 +86,7 @@ class SignFileService {
 	private string $userUniqueIdentifier = '';
 	private string $friendlyName = '';
 	private ?IUser $user = null;
-	private ?ISignEngineHandler $engine = null;
+	private ?IPkcs12SignEngineHandler $engine = null;
 
 	public function __construct(
 		protected IL10N $l10n,