NotificationsService has no unit tests: only the gateway spec exists

[nanaf6203-bit]

NotificationsService has no unit tests: only the gateway spec exists

Labels / Complexity: testing · Medium Complexity — Medium

Problem

src/notifications/ has exactly one spec — notifications.gateway.spec.ts. The module's core, NotificationsService (which creates, delivers, and persists notifications across email/SMS/in-app channels), is untested. The SMS channel also carries the in-memory rate limiter (#55) whose behavior needs pinning before it is migrated. A regression in delivery selection or persistence ships silently.

Why this is architecturally hard

1. Channel selection is the test design. Notifications fan out to multiple channels based on user prefs; tests must pin which channels fire for which preferences.
2. Persistence + delivery are separate concerns. Tests should cover the Prisma write path (via test/database or mocks) and the transport dispatch (via transport stubs) independently.
3. The rate limiter must be pinned. With Input validation and sanitization #55 migrating the SMS rate limit, tests written now freeze the current window semantics so the migration cannot change them.

Acceptance criteria

• Unit tests cover notification creation, channel selection, persistence, and delivery dispatch.
• SMS rate-limit behavior (window, cap, reset) is pinned by tests.
• Tests run in CI via npm test; the PR reports coverage via npm run test:cov.

Out of scope

The rate-limit durability migration (#55); notification behavior changes.

Getting started

• src/notifications/notifications.service.ts — the core to cover
• src/notifications/notifications.gateway.spec.ts — the existing spec style

Commands: npm test, npm run test:cov.

Good first files to read: src/notifications/notifications.service.ts, src/notifications/notifications.gateway.spec.ts.

[kaizercodes]

@kaizercodes has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

hi maintainer, can i work on this?

ℹ️ Repo Maintainers: To accept this application, review their application or assign @kaizercodes to this issue.

[Grazial-hash]

@Grazial-hash has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Can i please work on this

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Grazial-hash to this issue.

[Okibe2002]

@Okibe2002 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi, I've carefully reviewed the issue details and am confident I can provide a clean, efficient, and well-tested implementation that addresses the requirements.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Okibe2002 to this issue.

[yellowmam77]

@yellowmam77 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.

Hi Maintainer! I'm a senior developer with experience building high-quality, production-ready software. I'd love to take on this issue and deliver a clean, well-tested solution that aligns with the project's standards. Please assign it to me—I'm ready to get started and contribute effectively.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @yellowmam77 to this issue.

[drips-wave]

Congratulations, @yellowmam77! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.

🧑‍💻 @yellowmam77: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

Warning

When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

🌊 Happy Wave 🌊