Repository navigation
Conversation
"Override the web client origin URL" reads as if the variable also redirects the asset download in require_web_client_static_dir(). It does not: it is the navigation target baked into the bookmark URL handed to the headset. build_headset_bookmark_url() accepts values carrying a query string, which urljoin() could never resolve an asset path against, so the two can never be the same knob. The wording now matches the adjacent TELEOP_PROXY_HOST row, which already scopes itself to bookmark URLs. Pre-staging assets is TELEOP_WEB_CLIENT_STATIC_DIR's job, documented in quick_start. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Override the web client origin URL" reads as if
TELEOP_WEB_CLIENT_BASEalso redirects the asset download inrequire_web_client_static_dir(). It does not: it is the navigation target baked into the bookmark URL handed to the headset.The two can never be the same knob.
build_headset_bookmark_url()accepts values carrying a query string (https://host/app?theme=dark), whichurljoin()could never resolve an asset path against — it would yieldhttps://host/bundle.js. Pre-staging assets isTELEOP_WEB_CLIENT_STATIC_DIR's job, documented under "Offline / air-gapped use" in quick_start.The new wording matches the adjacent
TELEOP_PROXY_HOSTrow, which already scopes itself to bookmark URLs.Validation
:widths: 30 70unchanged, zero system messagesSKIP=check-copyright-year pre-commit run --all-filesDocs-only; no behaviour change.