feat(tvos): support current V8 runtime and source-built reviewer setup

Author: LorenzGit

.gitignore

@@ -93,3 +93,7 @@ NativeScript/inspector/absl/
 #AI agents
 .claude/*
 !.claude/settings.json
+
+NativeScript/lib/arm64-appletvos/
+NativeScript/lib/arm64-appletvsimulator/
+NativeScript/lib/.tvos-v8-version

NativeScript/runtime/NativeScriptException.mm

@@ -1442,8 +1442,11 @@ static void ShowErrorModalSynchronously(const std::string& title, const std::str
                                                  alpha:1.0];  // Terminal green
   stackTraceTextView.backgroundColor = [UIColor clearColor];
   stackTraceTextView.font = [UIFont fontWithName:@"Menlo" size:16];  // Monospace
+#if !TARGET_OS_TV
+  // tvOS UITextView is never editable/selectable; the properties do not exist there.
   stackTraceTextView.editable = NO;
   stackTraceTextView.selectable = YES;
+#endif
   stackTraceTextView.scrollEnabled = YES;
   stackTraceTextView.contentInset = UIEdgeInsetsMake(15, 15, 15, 15);
   stackTraceTextView.translatesAutoresizingMaskIntoConstraints = NO;

build_all_tvos.sh

@@ -0,0 +1,17 @@
+#!/bin/bash
+set -e
+
+# tvOS archives must be built for this runtime's pinned V8 version.
+./scripts/install-tvos-v8.sh "${V8_TVOS_BUILD:?Set V8_TVOS_BUILD to the built v8-buildscripts checkout}"
+# Keep the matching source-built headers and inspector sources.
+export V8_SKIP_DOWNLOAD=1
+git submodule update --init libffi
+./build_libffi.sh --install arm64-appletvos arm64-appletvsimulator
+./tools/update-xcode-env.sh
+rm -rf ./dist
+./update_version.sh
+./build_metadata_generator.sh
+./build_nativescript.sh --no-catalyst --no-iphone --no-sim --no-vision --tvos
+./build_tklivesync.sh --no-catalyst --no-iphone --no-sim --no-vision --tvos
+./prepare_dSYMs.sh
+./build_npm_tvos.sh

build_libffi.sh

@@ -29,6 +29,7 @@ ALL_SLICES=(
   x86_64-maccatalyst
 )
 
+TVOS_MIN=13.0
 IOS_MIN=13.0
 XROS_MIN=2.0
 CATALYST_MIN=13.3
@@ -41,6 +42,8 @@ Builds libffi from the ./libffi submodule for the given slices
 (default: all of ${ALL_SLICES[*]}).
 
 Options:
+  tvOS slices: arm64-appletvos arm64-appletvsimulator
+
   --install     also copy the built libraries and generated headers into
                 NativeScript/lib/<slice>/ and NativeScript/include/libffi/<arch>/
   --jobs N      parallel make jobs (default: number of CPUs)
@@ -98,6 +101,12 @@ slice_config() {
     arm64-iphonesimulator)
       echo "iphonesimulator|aarch64-apple-darwin|-arch arm64 -mios-simulator-version-min=$IOS_MIN"
       ;;
+    arm64-appletvos)
+      echo "appletvos|aarch64-apple-darwin|-target arm64-apple-tvos$TVOS_MIN"
+      ;;
+    arm64-appletvsimulator)
+      echo "appletvsimulator|aarch64-apple-darwin|-target arm64-apple-tvos$TVOS_MIN-simulator"
+      ;;
     arm64-xros)
       echo "xros|aarch64-apple-darwin|-target arm64-apple-xros$XROS_MIN"
       ;;

build_nativescript.sh

@@ -31,6 +31,7 @@ BUILD_CATALYST=$(to_bool ${BUILD_CATALYST:=true})
 BUILD_IPHONE=$(to_bool ${BUILD_IPHONE:=true})
 BUILD_SIMULATOR=$(to_bool ${BUILD_SIMULATOR:=true})
 BUILD_VISION=$(to_bool ${BUILD_VISION:=true})
+BUILD_TVOS=$(to_bool ${BUILD_TVOS:=false})
 VERBOSE=$(to_bool ${VERBOSE:=false})
 
 for arg in $@; do
@@ -43,6 +44,8 @@ for arg in $@; do
     --no-iphone|--no-device) BUILD_IPHONE=false ;;
     --xr|--vision) BUILD_VISION=true ;;
     --no-xr|--no-vision) BUILD_VISION=false ;;
+    --tv|--tvos) BUILD_TVOS=true ;;
+    --no-tv|--no-tvos) BUILD_TVOS=false ;;
     --verbose|-v) VERBOSE=true ;;
     *) ;;
   esac
@@ -60,14 +63,14 @@ mkdir -p $DIST
 mkdir -p $DIST/intermediates
 
 checkpoint "Cleanup NativeScript"
-xcodebuild -project v8ios.xcodeproj \
+xcodebuild SYMROOT="$DIST/build" -project v8ios.xcodeproj \
            -target "NativeScript" \
            -configuration Release clean \
            $QUIET
 
 if $BUILD_CATALYST; then
 checkpoint "Building NativeScript for Mac Catalyst"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme "NativeScript" \
                    -configuration Release \
                    -destination "platform=macOS,variant=Mac Catalyst" \
@@ -81,7 +84,7 @@ fi
 
 if $BUILD_SIMULATOR; then
 checkpoint "Building NativeScript for iphone simulators (multi-arch)"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme "NativeScript" \
                    -configuration Release \
                    -destination "generic/platform=iOS Simulator" \
@@ -96,7 +99,7 @@ fi
 
 if $BUILD_IPHONE; then
 checkpoint "Building NativeScript for ARM64 device"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme "NativeScript" \
                    -configuration Release \
                    -destination "generic/platform=iOS" \
@@ -111,7 +114,7 @@ fi
 
 if $BUILD_CATALYST; then
 checkpoint "Building NativeScript for Mac Catalyst"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme "NativeScript" \
                    -configuration Release \
                    -destination "generic/platform=macOS,variant=Mac Catalyst" \
@@ -125,7 +128,7 @@ fi
 if $BUILD_VISION; then
 
 checkpoint "Building NativeScript for visionOS Device"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme "NativeScript" \
                    -configuration Release \
                    -destination "generic/platform=visionOS" \
@@ -138,7 +141,7 @@ xcodebuild archive -project v8ios.xcodeproj \
                    -archivePath $DIST/intermediates/NativeScript.xros.xcarchive
 
 checkpoint "Building NativeScript for visionOS Simulators"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme "NativeScript" \
                    -configuration Release \
                    -destination "generic/platform=visionOS Simulator" \
@@ -151,6 +154,35 @@ xcodebuild archive -project v8ios.xcodeproj \
                    -archivePath $DIST/intermediates/NativeScript.xrsimulator.xcarchive
 fi
 
+if $BUILD_TVOS; then
+
+checkpoint "Building NativeScript for tvOS Device"
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
+                   -scheme "NativeScript" \
+                   -configuration Release \
+                   -destination "generic/platform=tvOS" \
+                   $QUIET \
+                   EXCLUDED_ARCHS="i386 x86_64" \
+                   VALID_ARCHS=arm64 \
+                   DEVELOPMENT_TEAM=$DEV_TEAM \
+                   SKIP_INSTALL=NO \
+                   BUILD_LIBRARY_FOR_DISTRIBUTION=YES \
+                   -archivePath $DIST/intermediates/NativeScript.appletvos.xcarchive
+
+checkpoint "Building NativeScript for tvOS Simulators"
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
+                   -scheme "NativeScript" \
+                   -configuration Release \
+                   -destination "generic/platform=tvOS Simulator" \
+                   $QUIET \
+                   EXCLUDED_ARCHS="i386 x86_64" \
+                   VALID_ARCHS=arm64 \
+                   DEVELOPMENT_TEAM=$DEV_TEAM \
+                   SKIP_INSTALL=NO \
+                   BUILD_LIBRARY_FOR_DISTRIBUTION=YES \
+                   -archivePath $DIST/intermediates/NativeScript.appletvsimulator.xcarchive
+fi
+
 XCFRAMEWORKS=()
 if $BUILD_CATALYST; then
   XCFRAMEWORKS+=( -framework "$DIST/intermediates/NativeScript.maccatalyst.xcarchive/Products/Library/Frameworks/NativeScript.framework" \
@@ -174,6 +206,13 @@ if $BUILD_VISION; then
                   -debug-symbols "$DIST/intermediates/NativeScript.xrsimulator.xcarchive/dSYMs/NativeScript.framework.dSYM" )
 fi
 
+if $BUILD_TVOS; then
+  XCFRAMEWORKS+=( -framework "$DIST/intermediates/NativeScript.appletvos.xcarchive/Products/Library/Frameworks/NativeScript.framework" \
+                  -debug-symbols "$DIST/intermediates/NativeScript.appletvos.xcarchive/dSYMs/NativeScript.framework.dSYM" )
+  XCFRAMEWORKS+=( -framework "$DIST/intermediates/NativeScript.appletvsimulator.xcarchive/Products/Library/Frameworks/NativeScript.framework" \
+                  -debug-symbols "$DIST/intermediates/NativeScript.appletvsimulator.xcarchive/dSYMs/NativeScript.framework.dSYM" )
+fi
+
 checkpoint "Creating NativeScript.xcframework"
 OUTPUT_DIR="$DIST/NativeScript.xcframework"
 rm -rf $OUTPUT_DIR

build_npm_tvos.sh

@@ -0,0 +1,36 @@
+#!/bin/bash
+set -e
+source "$(dirname "$0")/build_utils.sh"
+
+checkpoint "Preparing npm package for tvOS..."
+OUTPUT_DIR="dist/npm"
+rm -rf "$OUTPUT_DIR"
+mkdir -p "$OUTPUT_DIR"
+mkdir -p "$OUTPUT_DIR/framework"
+cp ./package.json "$OUTPUT_DIR"
+
+# Keep the template and runtime linkage in step with upstream iOS.
+cp -r "./project-template-ios/." "$OUTPUT_DIR/framework/"
+swift scripts/prepare-tvos-template.swift "$OUTPUT_DIR/framework"
+LOCAL_SPM_DIR="$OUTPUT_DIR/framework/internal/local-spm"
+mkdir -p "$LOCAL_SPM_DIR"
+cp spm-templates/local-spm-tvos/Package.swift "$LOCAL_SPM_DIR/"
+for framework in NativeScript TKLiveSync; do
+  (cd dist && zip -qr --symlinks "npm/framework/internal/local-spm/$framework.xcframework.zip" "$framework.xcframework")
+done
+
+mkdir -p "$OUTPUT_DIR/framework/internal/metadata-generator-x86_64"
+cp -r "metadata-generator/dist/x86_64/." "$OUTPUT_DIR/framework/internal/metadata-generator-x86_64"
+
+mkdir -p "$OUTPUT_DIR/framework/internal/metadata-generator-arm64"
+cp -r "metadata-generator/dist/arm64/." "$OUTPUT_DIR/framework/internal/metadata-generator-arm64"
+
+pushd "$OUTPUT_DIR"
+# Publish as @nativescript/tvos (same version as the iOS runtime it is built from) and drop the husky
+# "prepare" hook, which must not run for the published tarball.
+node -e 'const fs=require("fs");const p=JSON.parse(fs.readFileSync("package.json"));p.name="@nativescript/tvos";p.description="NativeScript Runtime for tvOS";delete p.scripts.prepare;fs.writeFileSync("package.json",JSON.stringify(p,null,2));'
+npm pack
+mv *.tgz ../
+popd
+
+checkpoint "npm package created."

build_tklivesync.sh

@@ -27,6 +27,7 @@ BUILD_CATALYST=$(to_bool ${BUILD_CATALYST:=true})
 BUILD_IPHONE=$(to_bool ${BUILD_IPHONE:=true})
 BUILD_SIMULATOR=$(to_bool ${BUILD_SIMULATOR:=true})
 BUILD_VISION=$(to_bool ${BUILD_VISION:=true})
+BUILD_TVOS=$(to_bool ${BUILD_TVOS:=false})
 VERBOSE=$(to_bool ${VERBOSE:=false})
 
 for arg in $@; do
@@ -39,6 +40,8 @@ for arg in $@; do
     --no-iphone|--no-device) BUILD_IPHONE=false ;;
     --xr|--vision) BUILD_VISION=true ;;
     --no-xr|--no-vision) BUILD_VISION=false ;;
+    --tv|--tvos) BUILD_TVOS=true ;;
+    --no-tv|--no-tvos) BUILD_TVOS=false ;;
     --verbose|-v) VERBOSE=true ;;
     *) ;;
   esac
@@ -51,15 +54,15 @@ mkdir -p $DIST/intermediates
 
 #cleanup
 checkpoint "Cleanup TKLiveSync"
-xcodebuild -project v8ios.xcodeproj \
+xcodebuild SYMROOT="$DIST/build" -project v8ios.xcodeproj \
            -target TKLiveSync \
            -configuration Release clean \
            -quiet
 
 if $BUILD_SIMULATOR; then
 # generates library for simulator targets (usually includes arm64, x86_64)
 checkpoint "Building TKLiveSync for iphone simulators (multi-arch)"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme TKLiveSync \
                    -configuration Release \
                    -destination "generic/platform=iOS Simulator" \
@@ -72,7 +75,7 @@ fi
 if $BUILD_IPHONE; then
 #generates library for device target
 checkpoint "Building TKLiveSync for ARM64 device"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme TKLiveSync \
                    -configuration Release \
                    -destination "generic/platform=iOS" \
@@ -85,7 +88,7 @@ fi
 if $BUILD_CATALYST; then
 #generates library for Mac Catalyst target
 checkpoint "Building TKLiveSync for Mac Catalyst"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme TKLiveSync \
                    -configuration Release \
                    -destination "generic/platform=macOS,variant=Mac Catalyst" \
@@ -98,7 +101,7 @@ fi
 if $BUILD_VISION; then
 #generates library for visionOS targets
 checkpoint "Building TKLiveSync for visionOS Simulators"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme "TKLiveSync" \
                    -configuration Release \
                    -destination "generic/platform=visionOS Simulator" \
@@ -108,7 +111,7 @@ xcodebuild archive -project v8ios.xcodeproj \
                    -archivePath $DIST/intermediates/TKLiveSync.xrsimulator.xcarchive
 
 checkpoint "Building TKLiveSync for visionOS Device"
-xcodebuild archive -project v8ios.xcodeproj \
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
                    -scheme "TKLiveSync" \
                    -configuration Release \
                    -destination "generic/platform=visionOS" \
@@ -118,6 +121,28 @@ xcodebuild archive -project v8ios.xcodeproj \
                    -archivePath $DIST/intermediates/TKLiveSync.xros.xcarchive
 fi
 
+if $BUILD_TVOS; then
+checkpoint "Building TKLiveSync for tvOS Simulators"
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
+                   -scheme "TKLiveSync" \
+                   -configuration Release \
+                   -destination "generic/platform=tvOS Simulator" \
+                   -quiet \
+                   SKIP_INSTALL=NO \
+                   BUILD_LIBRARY_FOR_DISTRIBUTION=YES \
+                   -archivePath $DIST/intermediates/TKLiveSync.appletvsimulator.xcarchive
+
+checkpoint "Building TKLiveSync for tvOS Device"
+xcodebuild archive -derivedDataPath "$DIST/DerivedData" -project v8ios.xcodeproj \
+                   -scheme "TKLiveSync" \
+                   -configuration Release \
+                   -destination "generic/platform=tvOS" \
+                   -quiet \
+                   SKIP_INSTALL=NO \
+                   BUILD_LIBRARY_FOR_DISTRIBUTION=YES \
+                   -archivePath $DIST/intermediates/TKLiveSync.appletvos.xcarchive
+fi
+
 #Creates directory for fat-library
 OUTPUT_DIR="$DIST/TKLiveSync.xcframework"
 rm -rf "${OUTPUT_PATH}"
@@ -161,6 +186,13 @@ if $BUILD_VISION; then
                   -debug-symbols "$DIST/intermediates/TKLiveSync.xrsimulator.xcarchive/dSYMs/TKLiveSync.framework.dSYM" )
 fi
 
+if $BUILD_TVOS; then
+  XCFRAMEWORKS+=( -framework "$DIST/intermediates/TKLiveSync.appletvos.xcarchive/Products/Library/Frameworks/TKLiveSync.framework" \
+                  -debug-symbols "$DIST/intermediates/TKLiveSync.appletvos.xcarchive/dSYMs/TKLiveSync.framework.dSYM" )
+  XCFRAMEWORKS+=( -framework "$DIST/intermediates/TKLiveSync.appletvsimulator.xcarchive/Products/Library/Frameworks/TKLiveSync.framework" \
+                  -debug-symbols "$DIST/intermediates/TKLiveSync.appletvsimulator.xcarchive/dSYMs/TKLiveSync.framework.dSYM" )
+fi
+
 checkpoint "Creating TKLiveSync.xcframework"
 OUTPUT_DIR="$DIST/TKLiveSync.xcframework"
 rm -rf $OUTPUT_DIR

metadata-generator/build-step-metadata-generator.py

@@ -1,6 +1,7 @@
 #!/usr/bin/env python3
 
 import os
+import re
 import shlex
 import subprocess
 import sys
@@ -66,17 +67,20 @@ def map_and_list(func, iterable):
 elif effective_platform_name == "-appletvos":
     docset_platform = "tvOS"
     default_deployment_target_flag_name = "-mappletvos-version-min"
-    default_deployment_target_clang_env_name = "APPLETVOS_DEPLOYMENT_TARGET"
+    default_deployment_target_clang_env_name = "TVOS_DEPLOYMENT_TARGET"
 elif effective_platform_name == "-appletvsimulator":
     docset_platform = "tvOS"
     default_deployment_target_flag_name = "-mappletvsimulator-version-min"
-    default_deployment_target_clang_env_name = "APPLETVOS_DEPLOYMENT_TARGET"
+    default_deployment_target_clang_env_name = "TVOS_DEPLOYMENT_TARGET"
 elif effective_platform_name == "-iphoneos":
     default_deployment_target_flag_name = "-miphoneos-version-min"
 
 sdk_version = env("SDK_VERSION") or "13.0"
 llvm_target_triple_suffix = env_or_empty("LLVM_TARGET_TRIPLE_SUFFIX")
-llvm_target_triple_os_version = "ios{}".format(sdk_version)
+# The OS part of the triple ("ios", "tvos", ...) comes from Xcode's LLVM_TARGET_TRIPLE_OS_VERSION
+# (e.g. "tvos16.0"); its version is the deployment target, so the SDK version is substituted instead.
+llvm_target_triple_os = re.sub(r"[0-9.]+$", "", env_or_empty("LLVM_TARGET_TRIPLE_OS_VERSION")) or "ios"
+llvm_target_triple_os_version = "{}{}".format(llvm_target_triple_os, sdk_version)
 # env("LLVM_TARGET_TRIPLE_OS_VERSION") is the deployment target, so doesn't have all APIs
 # usually it's ios9.0 for NativeScript projects
 llvm_target_triple_vendor = env("LLVM_TARGET_TRIPLE_VENDOR") or "apple"

package.json

@@ -30,7 +30,8 @@
     "setup-ci": "./build_metadata_generator.sh",
     "update-version": "./update_version.sh",
     "changelog": "conventional-changelog -p angular -i CHANGELOG.md -s",
-    "version": "npm run changelog && git add CHANGELOG.md"
+    "version": "npm run changelog && git add CHANGELOG.md",
+    "build-tvos": "node prepare-target tvos && ./build_all_tvos.sh"
   },
   "license": "Apache-2.0",
   "devDependencies": {