From 765efb18f3294b211dc58800cd4f09bb549f13e0 Mon Sep 17 00:00:00 2001 From: Craig Martin Date: Thu, 21 May 2026 15:56:14 -0400 Subject: [PATCH] Fix multiple-installation-warning snapshot padding after 4.0.0 bump MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The inline snapshots in this test interpolate `${CLI_KIT_VERSION}` into a UI box rendered by cli-kit's `info` renderer. The box auto-pads trailing whitespace to keep the box rectangular, so when CLI_KIT_VERSION shortened from 3.94.3 (6 chars) to 4.0.0 (5 chars), the renderer added one extra trailing space. The snapshot's literal whitespace did not follow, breaking main CI as soon as 4.0.0 landed. Adds one trailing space before the closing `│` on the three affected snapshot lines. Keeps the `${CLI_KIT_VERSION}` template literal rather than inlining `v4.0.0` so future same-length version bumps don't trip this again. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../node/plugins/multiple-installation-warning.test.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/cli-kit/src/public/node/plugins/multiple-installation-warning.test.ts b/packages/cli-kit/src/public/node/plugins/multiple-installation-warning.test.ts index f20c6cd87ed..dddda0afc4a 100644 --- a/packages/cli-kit/src/public/node/plugins/multiple-installation-warning.test.ts +++ b/packages/cli-kit/src/public/node/plugins/multiple-installation-warning.test.ts @@ -30,7 +30,7 @@ describe('showMultipleCLIWarningIfNeeded', () => { │ │ │ Two Shopify CLI installations found – using global installation │ │ │ - │ A global installation (v${CLI_KIT_VERSION}) and a local dependency (v3.70.0) were │ + │ A global installation (v${CLI_KIT_VERSION}) and a local dependency (v3.70.0) were │ │ detected. │ │ We recommend removing the @shopify/cli and @shopify/app dependencies from │ │ your package.json, unless you want to use different versions across │ @@ -62,7 +62,7 @@ describe('showMultipleCLIWarningIfNeeded', () => { │ │ │ Two Shopify CLI installations found – using local dependency │ │ │ - │ A global installation (v3.70.0) and a local dependency (v${CLI_KIT_VERSION}) were │ + │ A global installation (v3.70.0) and a local dependency (v${CLI_KIT_VERSION}) were │ │ detected. │ │ We recommend removing the @shopify/cli and @shopify/app dependencies from │ │ your package.json, unless you want to use different versions across │ @@ -95,7 +95,7 @@ describe('showMultipleCLIWarningIfNeeded', () => { │ │ │ Two Shopify CLI installations found – using global installation │ │ │ - │ A global installation (v${CLI_KIT_VERSION}) and a local dependency (v3.70.0) were │ + │ A global installation (v${CLI_KIT_VERSION}) and a local dependency (v3.70.0) were │ │ detected. │ │ We recommend removing the @shopify/cli and @shopify/app dependencies from │ │ your package.json, unless you want to use different versions across │