Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

[Feature] Add signature validation - #199

Closed
mkohei wants to merge 3 commits into
Shopify:mainfrom
mkohei:feat/_validate-signature
Closed

mkohei wants to merge 3 commits into
Shopify:mainfrom
mkohei:feat/_validate-signature

Conversation

@mkohei

@mkohei mkohei commented Jul 13, 2022 •

Copy link
Copy Markdown

WHY are these changes introduced?

Because there is no Signature verification when using app proxy.

WHAT is this pull request doing?

Add Utils::validateSignature($params, $secret)

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@mkohei
mkohei requested a review from a team as a code owner July 13, 2022 01:38
@ghost ghost added the cla-needed label Jul 13, 2022
@sebastianpisula

Copy link
Copy Markdown

great idea! It still works?

@wardwj

wardwj commented Feb 11, 2024

Copy link
Copy Markdown

Can we get this added? PR is still valid and works

@Suleimanlatrsh

Copy link
Copy Markdown
Contributor

Thanks for contributing! This package is deprecated and we're archiving this repo, so we're closing all open issues and PRs. Please use shopify-app-php instead, and open new issues there. More context: Rethinking support for PHP/Python packages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants