Skip to content
This repository was archived by the owner on Oct 6, 2026. It is now read-only.

Add missing webhook topic definitions - #241

Closed
frankiejarrett wants to merge 4 commits into
Shopify:mainfrom
frankiejarrett:add-missing-topics
Closed

frankiejarrett wants to merge 4 commits into
Shopify:mainfrom
frankiejarrett:add-missing-topics

Conversation

@frankiejarrett

@frankiejarrett frankiejarrett commented Jan 15, 2023 •

Copy link
Copy Markdown

WHY are these changes introduced?

As a best practice, apps should reference these constants rather than hardcoding topic strings in case they change in the future.

WHAT is this pull request doing?

Adds 48 missing webhook constants.

Full list: https://shopify.dev/api/admin-graphql/2023-01/enums/webhooksubscriptiontopic

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above
  • I have added/updated tests for this change
  • I have updated the documentation for public APIs from the library (if applicable)

@Suleimanlatrsh

Copy link
Copy Markdown
Contributor

Thanks for contributing! This package is deprecated and we're archiving this repo, so we're closing all open issues and PRs. Please use shopify-app-php instead, and open new issues there. More context: Rethinking support for PHP/Python packages

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants