Skip to content
This repository was archived by the owner on Dec 4, 2025. It is now read-only.

Commit 5e52bce

Browse files
authored
Merge pull request #879 from linwumingshi/fix/gprc-mac-doc
Grant execute permissions for protoc-gen-doc on Linux/Mac OS
2 parents c88db09 + 8488a6e commit 5e52bce

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

src/main/java/com/ly/doc/model/grpc/ProtoInfo.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import com.ly.doc.constants.DocGlobalConstants;
2424

2525
import java.io.Serializable;
26+
import java.util.logging.Logger;
2627

2728
/**
2829
* proto info.
@@ -31,6 +32,8 @@
3132
*/
3233
public class ProtoInfo implements Serializable {
3334

35+
private static final Logger log = Logger.getLogger(ProtoInfo.class.getName());
36+
3437
private static final long serialVersionUID = 4962891140273167418L;
3538

3639
/**
@@ -84,6 +87,8 @@ private ProtoInfo() {
8487
String os = System.getProperty("os.name").toLowerCase();
8588
String arch = System.getProperty("os.arch").toLowerCase();
8689

90+
log.info("The os.name is:" + os + "and os.arch is: " + arch);
91+
8792
this.setTargetJsonDirectoryPath(targetJsonPath);
8893
this.setJsonName("combined.json");
8994
this.setTargetJsonFilePath(targetJsonPath + this.getJsonName());
@@ -93,7 +98,7 @@ private ProtoInfo() {
9398
this.setSourcePaths("/protoc/win/protoc.exe", "/protoc/win/protoc-gen-doc.exe");
9499
}
95100
else if (os.contains("mac")) {
96-
if (arch.contains("arm")) {
101+
if (arch.contains("arm") || arch.contains("aarch")) {
97102
this.setSourcePaths("/protoc/mac/arm/protoc", "/protoc/mac/arm/protoc-gen-doc");
98103
}
99104
else {

src/main/java/com/ly/doc/template/GRpcDocBuildTemplate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ private void executeCommand(List<String> command, ProtoInfo protoInfo) {
302302
// Grant execute permissions
303303
Files.setPosixFilePermissions(Paths.get(protoInfo.getProtocPath()),
304304
PosixFilePermissions.fromString("rwxr-xr-x"));
305-
Files.setPosixFilePermissions(Paths.get(protoInfo.getProtocPath()),
305+
Files.setPosixFilePermissions(Paths.get(protoInfo.getProtocGenDocPath()),
306306
PosixFilePermissions.fromString("rwxr-xr-x"));
307307
}
308308
}

0 commit comments

Comments
 (0)