Skip to content

Commit 4dd678c

Browse files
authored
Improve cron schedule warning message (#227)
1 parent dfb411f commit 4dd678c

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

languageservice/src/validate.test.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,8 @@ jobs:
211211

212212
expect(result.length).toBe(1);
213213
expect(result[0]).toEqual({
214-
message: "Runs every minute. Note: Actions schedules run at most every 5 minutes.",
214+
message:
215+
'Actions schedules run at most every 5 minutes. "*/1 * * * *" (runs every minute) will not run as frequently as specified.',
215216
severity: DiagnosticSeverity.Warning,
216217
code: "on-schedule",
217218
codeDescription: {
@@ -281,7 +282,7 @@ jobs:
281282

282283
expect(result.length).toBe(1);
283284
expect(result[0]?.severity).toBe(DiagnosticSeverity.Warning);
284-
expect(result[0]?.message).toContain("Note: Actions schedules run at most every 5 minutes.");
285+
expect(result[0]?.message).toContain("Actions schedules run at most every 5 minutes.");
285286
});
286287

287288
it("invalid YAML", async () => {

languageservice/src/validate.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ function validateCronExpression(diagnostics: Diagnostic[], token: StringToken):
247247
// Check if the cron specifies an interval less than 5 minutes
248248
if (hasCronIntervalLessThan5Minutes(cronValue)) {
249249
diagnostics.push({
250-
message: `${description}. Note: Actions schedules run at most every 5 minutes.`,
250+
message: `Actions schedules run at most every 5 minutes. "${cronValue}" (${description.toLowerCase()}) will not run as frequently as specified.`,
251251
range: mapRange(token.range),
252252
severity: DiagnosticSeverity.Warning,
253253
code: "on-schedule",

0 commit comments

Comments
 (0)