Skip to content

Commit cc316ab

Browse files
authored
Remove phantom github.job_workflow_sha from language service (#347)
This property is listed in the GitHub context provider but is never populated at runtime by the runner. Users see it in autocomplete, use it in workflows, and it silently evaluates to empty string. Remove from keys array and description metadata.
1 parent d5670c3 commit cc316ab

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

languageservice/src/context-providers/descriptions.json

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -105,13 +105,6 @@
105105
"job": {
106106
"description": "The [`job_id`](https://docs.github.com/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_id) of the current job.\nNote: This context property is set by the Actions runner, and is only available within the execution `steps` of a job. Otherwise, the value of this property will be `null`."
107107
},
108-
"job_workflow_sha": {
109-
"description": "For jobs using a reusable workflow, the commit SHA for the reusable workflow file.",
110-
"versions": {
111-
"ghes": ">=3.9",
112-
"ghae": ">=3.9"
113-
}
114-
},
115108
"path": {
116109
"description": "Path on the runner to the file that sets system PATH variables from workflow commands. This file is unique to the current step and is a different file for each step in a job. For more information, see \"[Workflow commands for GitHub Actions](https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-system-path).\""
117110
},

languageservice/src/context-providers/github.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ export function getGithubContext(workflowContext: WorkflowContext | undefined, m
2929
"graphql_url",
3030
"head_ref",
3131
"job",
32-
"job_workflow_sha",
3332
"path",
3433
"ref",
3534
"ref_name",

0 commit comments

Comments
 (0)