Skip to content

Commit 6924f73

Browse files
author
Bryan Clark
committed
Address latest review feedback
1 parent 998be8d commit 6924f73

6 files changed

Lines changed: 424 additions & 421 deletions

File tree

README.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -72,22 +72,26 @@ jobs:
7272
server-id: github # Value of the distributionManagement/repository/id field of the pom.xml
7373
username: ${{ github.actor }} # username for server authentication
7474
password: ${{ github.token }} # password or token for authentication
75+
7576
- name: Build with Maven
7677
run: mvn -B package --file pom.xml
78+
7779
- name: Publish to GitHub Packages Apache Maven
7880
run: mvn deploy
81+
7982
- name: Set up Apache Maven Central
8083
uses: actions/setup-java@v1
8184
with: # running setup-java again overwrites the settings.xml
8285
java-version: 1.8
8386
server-id: maven
84-
username: maven_username
85-
password: ${{ secrets.MAVEN_CENTRAL_TOKEN }} # password from secrets store
87+
server-username: maven_username
88+
server-password: ${{ secrets.MAVEN_CENTRAL_TOKEN }} # password from secrets store
89+
8690
- name: Publish to Apache Maven Central
8791
run: mvn deploy
8892
```
8993
90-
***NOTE: The `settings.xml` file is created in the Actions $HOME directory. If you have an existing `settings.xml` file at that location, it will be overwritten***
94+
***NOTE: The `settings.xml` file is created in the Actions $HOME directory. If you have an existing `settings.xml` file at that location, it will be overwritten. See below for using the `settings-path` to change your `settings.xml` file location.***
9195

9296
See the help docs on [Publishing a Package](https://help.github.com/en/github/managing-packages-with-github-packages/configuring-apache-maven-for-use-with-github-packages#publishing-a-package) for more information on the `pom.xml` file.
9397

@@ -114,7 +118,7 @@ jobs:
114118
PASSWORD: ${{ secrets.GITHUB_TOKEN }}
115119
```
116120

117-
***NOTE: The `USERNAME` and `PASSWORD` need to correspond to the credentials environment variables used in the publishing section of your `build.gradle`..***
121+
***NOTE: The `USERNAME` and `PASSWORD` need to correspond to the credentials environment variables used in the publishing section of your `build.gradle`.***
118122

119123
See the help docs on [Publishing a Package with Gradle](https://help.github.com/en/github/managing-packages-with-github-packages/configuring-gradle-for-use-with-github-packages#example-using-gradle-groovy-for-a-single-package-in-a-repository) for more information on the `build.gradle` configuration file.
120124

@@ -135,11 +139,13 @@ jobs:
135139
with:
136140
java-version: 1.8
137141
server-id: github # Value of the distributionManagement/repository/id field of the pom.xml
138-
username: ${{ github.actor }} # username for server authentication
139-
password: ${{ github.token }} # password or token for authentication
142+
server-username: ${{ github.actor }} # username for server authentication
143+
server-password: ${{ github.token }} # password or token for authentication
140144
settings-path: ${{ github.workspace }} # location for the settings.xml file
145+
141146
- name: Build with Maven
142147
run: mvn -B package --file pom.xml
148+
143149
- name: Publish to GitHub Packages Apache Maven
144150
run: mvn deploy -s $GITHUB_WORKSPACE/settings.xml
145151
```

action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@ inputs:
2323
description: 'ID of the distributionManagement repository in the pom.xml
2424
file.'
2525
required: false
26-
username:
26+
server-username:
2727
description: 'Username for authentication to the Apache Maven repository.'
2828
required: false
29-
password:
29+
server-password:
3030
description: 'Password or token for authentication to the Apache Maven
3131
repository.'
3232
required: false

0 commit comments

Comments
 (0)