Skip to content

Commit cddbd6f

Browse files
authored
More particular on updates
1 parent c6de615 commit cddbd6f

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

.github/workflows/update-ghas-matrix.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,9 @@ Look specifically for:
7272
### Step 5: Evaluate Significance
7373

7474
Apply the significance filter from the instructions file:
75-
- **INCLUDE:** New functionality, major gaps addressed, Preview→GA transitions, new CodeQL toolcache versions, partner pattern count changes, new versions, counts
75+
- **INCLUDE:** New functionality, new features, major gaps addressed, Preview→GA transitions, new CodeQL toolcache versions, partner pattern count changes, new versions, counts
7676
- **EXCLUDE:** Minor bug fixes, new language/framework version support (e.g., Go 1.25, Swift 6.2), simple renames, UI tweaks without functional impact
7777

78-
Significant updates get a new row in the appropriate feature matrix. The description should link to details when possible:
79-
- Favor a specific docs page (in case furture content is moved - https://docs.github.com/en/enterprise-server@latest is favored over a specific version to future proof EOL server versions in docs). Review the https://docs.github.com/en/enterprise-server docs for that the given update to ensure the link is taking you a page where the appropriate feature is described.
80-
- Otherwise, point to a specific changelog link (under https://github.blog/changelog/) that lists out which version of GHES the feature will belong to.
81-
- Finally, if there is no appropriate link that mentions the feature, then fallback to just a text description without a hyperlink.
8278

8379
If there are no significant changes found, **do not create a PR**. Simply note that the matrix is up to date and exit.
8480

@@ -90,6 +86,12 @@ If significant changes were found, follow the matrix update rules from the instr
9086
2. **For minor version changes:** Update the relevant cells in existing columns (e.g., change ☑️ to ✅ when a feature goes GA in a patch release).
9187
3. **For new features:** Add new rows with descriptive names and deep-linked documentation URLs.
9288

89+
Significant updates get a new row in the appropriate feature matrix. The description should link to details when possible:
90+
- Favor a specific docs page (in case furture content is moved - https://docs.github.com/en/enterprise-server@latest is favored over a specific version to future proof EOL server versions in docs). Review the https://docs.github.com/en/enterprise-server docs for that the given update to ensure the link is taking you a page where the appropriate feature is described. Ensure the link is taking you to an actual docs page, not a table of contents for more docs pages.
91+
- Otherwise, point to a specific changelog link (under https://github.blog/changelog/) that lists out which version of GHES the feature will belong to.
92+
- Finally, if there is no appropriate link that mentions the feature, then fallback to just a text description without a hyperlink.
93+
94+
9395
For CodeQL toolcache versions, check: `https://docs.github.com/en/enterprise-server@<VERSION>/admin/managing-code-security/managing-github-advanced-security-for-your-enterprise/configuring-code-scanning-for-your-appliance`
9496

9597
For secret scanning partner pattern counts, check: `https://docs.github.com/en/enterprise-server@<VERSION>/code-security/secret-scanning/introduction/supported-secret-scanning-patterns`

0 commit comments

Comments
 (0)