Changes to address PR review comments

Author: data-douser

server/dist/ql-mcp-server.js

@@ -6,6 +6,8 @@
 import { spawn, ChildProcess } from 'child_process';
 import { EventEmitter } from 'events';
 import { setTimeout, clearTimeout } from 'timers';
+import { pathToFileURL } from 'url';
+import { join } from 'path';
 import { logger } from '../utils/logger';
 import { getProjectTmpDir } from '../utils/temp-dir';
 
@@ -263,7 +265,7 @@ export class CodeQLLanguageServer extends EventEmitter {
     }
 
     // Default to a project-local virtual URI rather than /tmp
-    const documentUri = uri || `file://${getProjectTmpDir('lsp-eval')}/eval.ql`;
+    const documentUri = uri || pathToFileURL(join(getProjectTmpDir('lsp-eval'), 'eval.ql')).href;
 
     return new Promise((resolve, reject) => {
       let diagnosticsReceived = false;

server/dist/ql-mcp-server.js.map

@@ -8,7 +8,8 @@ import { z } from 'zod';
 import { CodeQLLanguageServer, Diagnostic, LanguageServerOptions } from '../../lib/language-server';
 import { logger } from '../../utils/logger';
 import { getProjectTmpDir } from '../../utils/temp-dir';
-import { resolve } from 'path';
+import { join, resolve } from 'path';
+import { pathToFileURL } from 'url';
 
 // Global language server instance for reuse across evaluations
 let globalLanguageServer: CodeQLLanguageServer | null = null;
@@ -128,7 +129,7 @@ export async function evaluateQLCode({
     const languageServer = await getLanguageServer(serverOptions);
 
     // Generate unique URI for this evaluation
-    const evalUri = `file://${getProjectTmpDir('lsp-eval')}/eval_${Date.now()}.ql`;
+    const evalUri = pathToFileURL(join(getProjectTmpDir('lsp-eval'), `eval_${Date.now()}.ql`)).href;
 
     const diagnostics = await languageServer.evaluateQL(qlCode, evalUri);
 

server/src/lib/language-server.ts

@@ -8,7 +8,7 @@
 
 import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { z } from 'zod';
-import { resolve } from 'path';
+import { join, resolve } from 'path';
 import { findClassPosition } from './find-class-position';
 import { findPredicatePosition } from './find-predicate-position';
 import { logger } from '../../utils/logger';
@@ -43,7 +43,7 @@ export async function quickEvaluate({
       }
     }
 
-    const resolvedOutput = resolve(output_path || getProjectTmpDir('quickeval') + '/quickeval.bqrs');
+    const resolvedOutput = resolve(output_path || join(getProjectTmpDir('quickeval'), 'quickeval.bqrs'));
 
     // For now, return the resolved output path
     // In a full implementation, this would use the CodeQL CLI or query server