Skip to content

Commit 56118d6

Browse files
committed
Address PR #243 review feedback
1 parent 691f4a5 commit 56118d6

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

server/dist/codeql-development-mcp-server.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193973,8 +193973,11 @@ function registerCLITool(server, definition) {
193973193973
const lastDumpDilFlag = [...rawAdditionalArgs].reverse().find(
193974193974
(arg) => arg === "--dump-dil" || arg === "--no-dump-dil"
193975193975
);
193976-
if (lastDumpDilFlag === "--dump-dil") options["dump-dil"] = true;
193977-
else if (lastDumpDilFlag === "--no-dump-dil") options["dump-dil"] = false;
193976+
if (lastDumpDilFlag === "--dump-dil") {
193977+
options["dump-dil"] = true;
193978+
} else if (lastDumpDilFlag === "--no-dump-dil") {
193979+
options["dump-dil"] = false;
193980+
}
193978193981
if (lastDumpDilFlag !== void 0) {
193979193982
rawAdditionalArgs = rawAdditionalArgs.filter(
193980193983
(arg) => arg !== "--dump-dil" && arg !== "--no-dump-dil"

server/dist/codeql-development-mcp-server.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

server/src/lib/cli-tool-registry.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -575,8 +575,11 @@ export function registerCLITool(server: McpServer, definition: CLIToolDefinition
575575
const lastDumpDilFlag = [...rawAdditionalArgs].reverse().find(
576576
(arg) => arg === '--dump-dil' || arg === '--no-dump-dil',
577577
);
578-
if (lastDumpDilFlag === '--dump-dil') options['dump-dil'] = true;
579-
else if (lastDumpDilFlag === '--no-dump-dil') options['dump-dil'] = false;
578+
if (lastDumpDilFlag === '--dump-dil') {
579+
options['dump-dil'] = true;
580+
} else if (lastDumpDilFlag === '--no-dump-dil') {
581+
options['dump-dil'] = false;
582+
}
580583
if (lastDumpDilFlag !== undefined) {
581584
rawAdditionalArgs = rawAdditionalArgs.filter(
582585
(arg) => arg !== '--dump-dil' && arg !== '--no-dump-dil',

server/test/src/lib/cli-tool-registry.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -955,7 +955,7 @@ describe('registerCLITool handler behavior', () => {
955955
const handler = (mockServer.registerTool as ReturnType<typeof vi.fn>).mock.calls[0][2];
956956

957957
executeCodeQLCommand.mockResolvedValueOnce({
958-
stdout: 'DIL output here',
958+
stdout: '',
959959
stderr: '',
960960
success: true
961961
});

0 commit comments

Comments
 (0)