Skip to content

Commit 7d83ebe

Browse files
data-douserCopilot
andauthored
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Nathan Randall <70299490+data-douser@users.noreply.github.com>
1 parent ded841c commit 7d83ebe

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/instructions/github_workflows_yaml.instructions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
applyTo: '.github/{actions,workflows}/*.{yml,yaml}'
2+
applyTo: '.github/{actions,workflows}/**/*.{yml,yaml}'
33
description: 'Instructions for editing GitHub Actions workflows for this repository.'
44
---
55

@@ -12,7 +12,7 @@ This file contains instructions for working with GitHub Actions YAML files in th
1212
## REQUIREMENTS
1313

1414
- **ALWAYS run `npm run build-and-test` from the repo root directory and ensure it passes completely before committing any changes. This is MANDATORY and must be verified before every commit.**
15-
- **ALWAYS pin ALL external GitHub Actions to full-length commit SHAs, never to tags or branch names — including GitHub-maintained `actions/*` actions.** Add a trailing comment with the original tag for readability (e.g., `uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6`). To resolve a tag to its commit SHA, run `git ls-remote https://github.com/OWNER/REPO.git refs/tags/TAG` (or `refs/heads/BRANCH` for branch-based refs).
15+
- **ALWAYS pin ALL external GitHub Actions to full-length commit SHAs, never to tags or branch names — including GitHub-maintained `actions/*` actions.** Add a trailing comment with the original tag for readability (e.g., `uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6`). To resolve a tag to its underlying commit SHA (handling annotated tags correctly), run `git ls-remote https://github.com/OWNER/REPO.git refs/tags/TAG^{}`; for branch-based refs, use `refs/heads/BRANCH`.
1616
- ALWAYS use the principle of least privilege, and explicitly set `permissions` for workflows.
1717
- ALWAYS use valid YAML syntax and follow GitHub Actions workflow conventions.
1818
- ALWAYS follow best practices for GitHub Actions workflows including security, efficiency, and maintainability.

0 commit comments

Comments
 (0)