fix: cross-platform support for Windows compatibility

- Use pathToFileURL() instead of file:// string concatenation in:
  - server/src/ql-mcp-server.ts (entrypoint check)
  - server/src/tools/codeql/language-server-eval.ts (workspace URI)
  - client/src/ql-mcp-client.js (entrypoint check)
- Fix path.includes() to normalize separators in cli-tool-registry.ts
- Replace .split('/').pop() with path.basename() for cross-platform path handling
- Update client-integration-tests.yml to run on matrix of ubuntu-latest and windows-latest
- Add platform-specific CI steps for process cleanup and OS dependencies
- Update setup-codeql-environment action with Windows cache paths

Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>

Author: Copilot

.github/actions/setup-codeql-environment/action.yml

@@ -75,8 +75,9 @@ runs:
         echo "  CodeQL Version: $CODEQL_VERSION"
         echo "  Cache Key: $CODEQL_CACHE_KEY"
 
-    - name: Cache `gh-codeql` extension and CodeQL packages
-      id: cache-codeql
+    - name: Cache `gh-codeql` extension and CodeQL packages (Unix)
+      id: cache-codeql-unix
+      if: runner.os != 'Windows'
       uses: actions/cache@v4
       with:
         path: |
@@ -86,6 +87,18 @@ runs:
         restore-keys: |
           gh-codeql-${{ runner.os }}-${{ steps.codeql-version.outputs.codeql-version }}-
 
+    - name: Cache `gh-codeql` extension and CodeQL packages (Windows)
+      id: cache-codeql-windows
+      if: runner.os == 'Windows'
+      uses: actions/cache@v4
+      with:
+        path: |
+          ~\AppData\Local\GitHub\gh-codeql
+          ~\.codeql\packages
+        key: ${{ steps.codeql-version.outputs.codeql-cache-key }}
+        restore-keys: |
+          gh-codeql-${{ runner.os }}-${{ steps.codeql-version.outputs.codeql-version }}-
+
     # Install GitHub CLI CodeQL extension and set `codeql` CLI version
     - name: Install GitHub CLI CodeQL extension and set version
       id: install-gh-codeql

.github/workflows/client-integration-tests.yml

@@ -26,7 +26,13 @@ permissions:
 
 jobs:
   integration-tests:
-    runs-on: ubuntu-latest
+    name: Integration Tests (${{ matrix.os }})
+    runs-on: ${{ matrix.os }}
+
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest]
 
     env:
       HTTP_HOST: 'localhost'
@@ -44,9 +50,14 @@ jobs:
           cache: 'npm'
           node-version-file: '.node-version'
 
-      - name: MCP Integration Tests - Install OS dependencies
+      - name: MCP Integration Tests - Install OS dependencies (Ubuntu)
+        if: runner.os == 'Linux'
         run: sudo apt-get install -y jq
 
+      - name: MCP Integration Tests - Install OS dependencies (Windows)
+        if: runner.os == 'Windows'
+        run: choco install jq -y
+
       - name: MCP Integration Tests - Install node dependencies for client and server workspaces
         run: npm ci --workspace=client && npm ci --workspace=server
 
@@ -57,10 +68,12 @@ jobs:
 
       ## Install packs used in the integration tests.
       - name: MCP Integration Tests - Install CodeQL packs
+        shell: bash
         run: ./server/scripts/install-packs.sh
 
       ## Extract test databases used in the integration tests.
       - name: MCP Integration Tests - Extract test databases
+        shell: bash
         run: ./server/scripts/extract-test-databases.sh
 
       ## Run integration tests. This script builds the server bundle and runs tests.
@@ -69,8 +82,8 @@ jobs:
       - name: MCP Integration Tests - Run integration tests
         run: npm run test:integration --workspace=client
 
-      - name: MCP Integration Tests - Stop the background MCP server process
-        if: always()
+      - name: MCP Integration Tests - Stop the background MCP server process (Unix)
+        if: always() && runner.os != 'Windows'
         run: |
           if [ -f server.pid ]; then
             PID=$(cat server.pid)
@@ -96,3 +109,38 @@ jobs:
             echo "Removing server.log"
             rm server.log
           fi
+
+      - name: MCP Integration Tests - Stop the background MCP server process (Windows)
+        if: always() && runner.os == 'Windows'
+        shell: pwsh
+        run: |
+          if (Test-Path server.pid) {
+            $PID = Get-Content server.pid
+            Write-Host "Stopping server with PID $PID"
+            try {
+              $process = Get-Process -Id $PID -ErrorAction SilentlyContinue
+              if ($process) {
+                Stop-Process -Id $PID -Force -ErrorAction SilentlyContinue
+                Start-Sleep -Seconds 2
+              } else {
+                Write-Host "Server process was not running"
+              }
+            } catch {
+              Write-Host "Server process was not running or already stopped"
+            }
+            Remove-Item server.pid -Force -ErrorAction SilentlyContinue
+          } else {
+            Write-Host "No server.pid file found"
+          }
+
+          # Clean up log files
+          if (Test-Path server.log) {
+            Write-Host "Removing server.log"
+            Remove-Item server.log -Force -ErrorAction SilentlyContinue
+          }
+
+      - name: MCP Integration Tests - Summary
+        shell: bash
+        run: |
+          echo "## Integration Tests Summary (${{ matrix.os }})" >> $GITHUB_STEP_SUMMARY
+          echo "✅ MCP server integration tests passed on ${{ matrix.os }}" >> $GITHUB_STEP_SUMMARY

client/src/ql-mcp-client.js

@@ -11,7 +11,7 @@ import { Client } from "@modelcontextprotocol/sdk/client/index.js";
 import { StreamableHTTPClientTransport } from "@modelcontextprotocol/sdk/client/streamableHttp.js";
 import { execSync } from "child_process";
 import dotenv from "dotenv";
-import { fileURLToPath } from "url";
+import { fileURLToPath, pathToFileURL } from "url";
 import path from "path";
 
 import { IntegrationTestRunner } from "./lib/integration-test-runner.js";
@@ -807,7 +807,7 @@ async function main() {
 }
 
 // Run if called directly
-if (import.meta.url === `file://${process.argv[1]}`) {
+if (import.meta.url === pathToFileURL(process.argv[1]).href) {
   main().catch((error) => {
     console.error("Fatal error:", error);
     process.exit(1);

server/dist/ql-mcp-server.js

@@ -9,17 +9,19 @@ import { logger } from '../utils/logger';
 import { evaluateQueryResults, QueryEvaluationResult, extractQueryMetadata } from './query-results-evaluator';
 import { getOrCreateLogDirectory } from './log-directory-manager';
 import { writeFileSync, rmSync, existsSync, mkdirSync } from 'fs';
-import { join, dirname, resolve } from 'path';
+import { join, dirname, resolve, basename } from 'path';
 import { createProjectTempDir } from '../utils/temp-dir';
 import { fileURLToPath } from 'url';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 // Calculate the repository root directory
 // When running from source: server/src/lib/ -> go up 3 levels to repo root
-// When running from bundle: server/dist/ -> go up 2 levels to repo root  
+// When running from bundle: server/dist/ -> go up 2 levels to repo root
 // The bundled file flattens the structure, so we detect based on path
-const repoRootDir = __dirname.includes('src/lib') 
+// Normalize path separators for cross-platform compatibility (Windows uses '\', Unix uses '/')
+const normalizedDir = __dirname.split(/[\\/]/).join('/');
+const repoRootDir = normalizedDir.includes('src/lib')
   ? resolve(__dirname, '..', '..', '..')  // From source: server/src/lib -> repo root
   : resolve(__dirname, '..', '..');        // From bundle: server/dist -> repo root
 
@@ -637,13 +639,13 @@ async function resolveQueryPath(
 
     // Find the query that matches the requested name exactly
     const matchingQuery = resolvedQueries.find(queryPath => {
-      const fileName = queryPath.split('/').pop();
+      const fileName = basename(queryPath);
       // Match exact query name: "PrintAST" should match "PrintAST.ql" only
       return fileName === `${queryName}.ql`;
     });
-    
+
     if (!matchingQuery) {
-      logger.error(`Query "${queryName}.ql" not found in pack "${packPath}". Available queries:`, resolvedQueries.map(q => q.split('/').pop()));
+      logger.error(`Query "${queryName}.ql" not found in pack "${packPath}". Available queries:`, resolvedQueries.map(q => basename(q)));
       throw new Error(`Query "${queryName}.ql" not found in pack "${packPath}"`);
     }
 

server/dist/ql-mcp-server.js.map

@@ -7,6 +7,7 @@
 
 import { McpServer } from '@modelcontextprotocol/sdk/server/mcp.js';
 import { z } from 'zod';
+import { basename } from 'path';
 import { loadPromptTemplate, processPromptTemplate } from './prompt-loader';
 import { logger } from '../utils/logger';
 
@@ -154,10 +155,8 @@ export function registerWorkflowPrompts(server: McpServer): void {
       // Derive workshop name from query path if not provided
       const derivedName =
         workshopName ||
-        queryPath
-          .split('/')
-          .pop()
-          ?.replace(/\.(ql|qlref)$/, '')
+        basename(queryPath)
+          .replace(/\.(ql|qlref)$/, '')
           .toLowerCase()
           .replace(/[^a-z0-9]+/g, '-') ||
         'codeql-workshop';

server/src/lib/cli-tool-registry.ts

@@ -9,6 +9,7 @@ import { StreamableHTTPServerTransport } from '@modelcontextprotocol/sdk/server/
 import express from 'express';
 import cors from 'cors';
 import dotenv from 'dotenv';
+import { pathToFileURL } from 'url';
 import { registerCodeQLTools, registerCodeQLResources } from './tools';
 import { registerLanguageResources } from './resources/language-resources';
 import { registerWorkflowPrompts } from './prompts/workflow-prompts';
@@ -140,6 +141,6 @@ async function main(): Promise<void> {
 }
 
 // Start the server if this file is run directly
-if (import.meta.url === `file://${process.argv[1]}`) {
+if (import.meta.url === pathToFileURL(process.argv[1]).href) {
   main();
 }

server/src/prompts/workflow-prompts.ts

@@ -103,7 +103,7 @@ async function getLanguageServer(options: LanguageServerOptions = {}): Promise<C
     await globalLanguageServer.start();
 
     // Use provided workspace URI or default to ql directory
-    const workspaceUri = `file://${resolve(process.cwd(), 'ql')}`;
+    const workspaceUri = pathToFileURL(resolve(process.cwd(), 'ql')).href;
     await globalLanguageServer.initialize(workspaceUri);
 
     logger.info('CodeQL Language Server started and initialized successfully');