Skip to content

Commit 0410ed3

Browse files
committed
Patch for cap remoteflowsource ServiceinCDSHandlerParameter
use last arg pos for source, not hardcoded index fix type from accidental function description to actual parameter
1 parent da65203 commit 0410ed3

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

javascript/frameworks/cap/lib/advanced_security/javascript/frameworks/cap/RemoteFlowSources.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ class HandlerParameter extends ParameterNode, RemoteFlowSource {
3737
* ```
3838
* parameters named `req` are captured in the above example.
3939
*/
40-
class ServiceinCDSHandlerParameter extends RemoteFlowSource {
40+
class ServiceinCDSHandlerParameter extends ParameterNode, RemoteFlowSource {
4141
ServiceinCDSHandlerParameter() {
4242
exists(MethodCallNode m, CdlEntity service, string serviceName |
4343
service.getName().regexpReplaceAll(".*\\.", "") = serviceName and
4444
m.getArgument(1).toString().regexpReplaceAll("'", "") = serviceName and
45-
this = m.getArgument(2) and
45+
this = m.getArgument(m.getNumArgument() - 1).(FunctionNode).getParameter(0) and
4646
m.getMethodName() in ["on", "before", "after"]
4747
)
4848
}

0 commit comments

Comments
 (0)