Address PR review comments

Author: data-douser

.gitignore

@@ -79,4 +79,5 @@ dbs
 
 # workspace customization file
 codeql-sap-js.code-workspace
+.vscode/settings.json
 

extractors/cds/tools/dist/cds-extractor.bundle.js

@@ -23,13 +23,9 @@
     "test:coverage": "npm run build:tests && jest --coverage"
   },
   "dependencies": {
-    "child_process": "^1.0.2",
-    "fs": "^0.0.2",
     "glob": "^13.0.6",
     "js-yaml": "^4.1.1",
     "minimatch": "^10.2.4",
-    "os": "^0.1.2",
-    "path": "^0.12.7",
     "tmp": "^0.2.5"
   },
   "devDependencies": {

extractors/cds/tools/dist/cds-extractor.bundle.js.map

@@ -1,7 +1,7 @@
 import { existsSync, readFileSync } from 'fs';
 import { join } from 'path';
 
-import jsYaml from 'js-yaml';
+import { load as yamlLoad } from 'js-yaml';
 import { minimatch } from 'minimatch';
 
 import { cdsExtractorLog } from './logging';
@@ -66,9 +66,10 @@ export function getPathsIgnorePatterns(sourceRoot: string): string[] {
 
   try {
     const content = readFileSync(configPath, 'utf8');
-    const config = jsYaml.load(content) as CodeqlConfig | null;
+    const config = yamlLoad(content) as CodeqlConfig | null;
 
     if (!config || !Array.isArray(config['paths-ignore'])) {
+      patternsCache.set(sourceRoot, []);
       return [];
     }
 
@@ -106,18 +107,20 @@ export function getPathsIgnorePatterns(sourceRoot: string): string[] {
  * @returns true if the path should be ignored
  */
 export function shouldIgnorePath(relativePath: string, patterns: string[]): boolean {
+  const matchOptions = { dot: true, windowsPathsNoEscape: true };
+
   for (const raw of patterns) {
     // Strip trailing slashes so `vendor/` is treated the same as `vendor`
     const pattern = raw.replace(/\/+$/, '');
 
     // Direct minimatch check
-    if (minimatch(relativePath, pattern, { dot: true })) {
+    if (minimatch(relativePath, pattern, matchOptions)) {
       return true;
     }
 
     // Also match as a directory prefix: pattern `vendor` should
     // match `vendor/lib/foo.cds` (i.e. anything nested underneath).
-    if (minimatch(relativePath, `${pattern}/**`, { dot: true })) {
+    if (minimatch(relativePath, `${pattern}/**`, matchOptions)) {
       return true;
     }
   }

extractors/cds/tools/dist/compile-test-cds-lib.cjs.map

@@ -1,6 +1,6 @@
 import { existsSync, readFileSync } from 'fs';
 
-import jsYaml from 'js-yaml';
+import { load as yamlLoad } from 'js-yaml';
 
 import {
   clearPathsIgnoreCache,
@@ -70,7 +70,7 @@ describe('paths-ignore', () => {
         (p: string) => p === '/source/.github/codeql/codeql-config.yml',
       );
       (readFileSync as jest.Mock).mockReturnValue('yaml-content');
-      (jsYaml.load as jest.Mock).mockReturnValue({
+      (yamlLoad as jest.Mock).mockReturnValue({
         name: 'My CodeQL config',
         'paths-ignore': ['src/node_modules', '**/*.test.js'],
         queries: [{ uses: 'security-extended' }],
@@ -92,7 +92,7 @@ describe('paths-ignore', () => {
         (p: string) => p === '/source/.github/codeql/codeql-config.yml',
       );
       (readFileSync as jest.Mock).mockReturnValue('yaml-content');
-      (jsYaml.load as jest.Mock).mockReturnValue({
+      (yamlLoad as jest.Mock).mockReturnValue({
         name: 'My CodeQL config',
         queries: [{ uses: 'security-extended' }],
       });
@@ -106,7 +106,7 @@ describe('paths-ignore', () => {
         (p: string) => p === '/source/.github/codeql/codeql-config.yml',
       );
       (readFileSync as jest.Mock).mockReturnValue('yaml-content');
-      (jsYaml.load as jest.Mock).mockReturnValue({
+      (yamlLoad as jest.Mock).mockReturnValue({
         'paths-ignore': ['vendor/**', 'test/data'],
       });
 
@@ -119,7 +119,7 @@ describe('paths-ignore', () => {
         (p: string) => p === '/source/.github/codeql/codeql-config.yml',
       );
       (readFileSync as jest.Mock).mockReturnValue('yaml-content');
-      (jsYaml.load as jest.Mock).mockReturnValue({
+      (yamlLoad as jest.Mock).mockReturnValue({
         'paths-ignore': ['vendor'],
       });
 
@@ -136,7 +136,7 @@ describe('paths-ignore', () => {
         (p: string) => p === '/source/.github/codeql/codeql-config.yml',
       );
       (readFileSync as jest.Mock).mockReturnValue('{{invalid');
-      (jsYaml.load as jest.Mock).mockImplementation(() => {
+      (yamlLoad as jest.Mock).mockImplementation(() => {
         throw new Error('YAML parse error');
       });
 
@@ -161,7 +161,7 @@ describe('paths-ignore', () => {
         (p: string) => p === '/source/.github/codeql/codeql-config.yml',
       );
       (readFileSync as jest.Mock).mockReturnValue('yaml-content');
-      (jsYaml.load as jest.Mock).mockReturnValue({
+      (yamlLoad as jest.Mock).mockReturnValue({
         'paths-ignore': ['vendor', '', null, 42, 'test'],
       });
 
@@ -174,7 +174,7 @@ describe('paths-ignore', () => {
         (p: string) => p === '/source/.github/codeql/codeql-config.yml',
       );
       (readFileSync as jest.Mock).mockReturnValue('');
-      (jsYaml.load as jest.Mock).mockReturnValue(null);
+      (yamlLoad as jest.Mock).mockReturnValue(null);
 
       const result = getPathsIgnorePatterns('/source');
       expect(result).toEqual([]);
@@ -185,7 +185,7 @@ describe('paths-ignore', () => {
         (p: string) => p === '/source/.github/codeql/codeql-config.yml',
       );
       (readFileSync as jest.Mock).mockReturnValue('yaml-content');
-      (jsYaml.load as jest.Mock).mockReturnValue({
+      (yamlLoad as jest.Mock).mockReturnValue({
         'paths-ignore': 'not-an-array',
       });