Skip to content

Commit 161d645

Browse files
committed
fix: update-release-version.sh for explicit versions
The update_internal_deps function was missing two YAML dependency formats used in qlpack.yml files: - Quoted exact versions without caret: `pack-name: "2.25.0"` - Quoted pack names: `"pack-name": "2.25.0"` This caused internal dependency references to remain at the old version when running a version bump, while only the `version:` fields updated.
1 parent 71bb397 commit 161d645

File tree

9 files changed

+26
-21
lines changed

9 files changed

+26
-21
lines changed

javascript/frameworks/cap/src/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ suites: codeql-suites
66
extractor: javascript
77
dependencies:
88
codeql/javascript-all: "^2.6.24"
9-
advanced-security/javascript-sap-cap-all: "2.25.0"
9+
advanced-security/javascript-sap-cap-all: "2.25.1"
1010
default-suite-file: codeql-suites/javascript-code-scanning.qls

javascript/frameworks/cap/test/qlpack.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ version: 2.25.1
44
extractor: javascript
55
dependencies:
66
codeql/javascript-all: "^2.6.24"
7-
advanced-security/javascript-sap-cap-queries: "2.25.0"
8-
advanced-security/javascript-sap-cap-models: "2.25.0"
9-
advanced-security/javascript-sap-cap-all: "2.25.0"
7+
advanced-security/javascript-sap-cap-queries: "2.25.1"
8+
advanced-security/javascript-sap-cap-models: "2.25.1"
9+
advanced-security/javascript-sap-cap-all: "2.25.1"

javascript/frameworks/ui5-webcomponents/test/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ version: 2.25.1
33
extractor: javascript
44
dependencies:
55
codeql/javascript-all: "^2.6.24"
6-
advanced-security/javascript-sap-ui5-all: "2.25.0"
6+
advanced-security/javascript-sap-ui5-all: "2.25.1"

javascript/frameworks/ui5/src/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ suites: codeql-suites
66
extractor: javascript
77
dependencies:
88
codeql/javascript-all: "^2.6.24"
9-
advanced-security/javascript-sap-ui5-all: "2.25.0"
9+
advanced-security/javascript-sap-ui5-all: "2.25.1"
1010
default-suite-file: codeql-suites/javascript-code-scanning.qls

javascript/frameworks/ui5/test/qlpack.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@ dependencies:
77
# no overlap occurs with the SAP UI5 queries. We therefore allow any version
88
# greater than or equal to 1.2.0, as major breaking changes are not a concern.
99
codeql/javascript-queries: ">1.2.0"
10-
advanced-security/javascript-sap-ui5-queries: "2.25.0"
11-
advanced-security/javascript-sap-ui5-models: "2.25.0"
12-
advanced-security/javascript-sap-ui5-all: "2.25.0"
10+
advanced-security/javascript-sap-ui5-queries: "2.25.1"
11+
advanced-security/javascript-sap-ui5-models: "2.25.1"
12+
advanced-security/javascript-sap-ui5-all: "2.25.1"

javascript/frameworks/xsjs/src/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ suites: codeql-suites
66
extractor: javascript
77
dependencies:
88
codeql/javascript-all: "^2.6.24"
9-
advanced-security/javascript-sap-xsjs-all: "2.25.0"
9+
advanced-security/javascript-sap-xsjs-all: "2.25.1"
1010
default-suite-file: codeql-suites/javascript-code-scanning.qls

javascript/frameworks/xsjs/test/qlpack.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@ version: 2.25.1
44
extractor: javascript
55
dependencies:
66
codeql/javascript-all: "^2.6.24"
7-
advanced-security/javascript-sap-xsjs-queries: "2.25.0"
8-
advanced-security/javascript-sap-xsjs-all: "2.25.0"
9-
advanced-security/javascript-sap-xsjs-models: "2.25.0"
7+
advanced-security/javascript-sap-xsjs-queries: "2.25.1"
8+
advanced-security/javascript-sap-xsjs-all: "2.25.1"
9+
advanced-security/javascript-sap-xsjs-models: "2.25.1"

javascript/heuristic-models/tests/qlpack.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,4 @@ version: 2.25.1
55
extractor: javascript
66
dependencies:
77
"codeql/javascript-all": "^2.6.24"
8-
"advanced-security/javascript-heuristic-models": "2.25.0"
8+
advanced-security/javascript-heuristic-models: "2.25.1"

scripts/update-release-version.sh

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -258,9 +258,11 @@ update_qlt_config() {
258258
}
259259

260260
## Update internal dependency references in a qlpack.yml file
261-
## e.g., advanced-security/javascript-sap-cap-models: "^2.3.0" -> "^2.4.0"
262-
## e.g., advanced-security/javascript-sap-cap-models: "^2.3.0" -> "^2.4.0-alpha"
263-
## and advanced-security/javascript-heuristic-models: 2.3.0 -> 2.4.0
261+
## Handles all YAML key-value formats used across qlpack files:
262+
## e.g., advanced-security/javascript-sap-cap-models: "^2.3.0" -> "^2.4.0"
263+
## e.g., advanced-security/javascript-sap-cap-models: "2.3.0" -> "2.4.0"
264+
## e.g., "advanced-security/javascript-heuristic-models": "2.3.0" -> ... (quoted key)
265+
## and advanced-security/javascript-heuristic-models: 2.3.0 -> 2.4.0
264266
update_internal_deps() {
265267
local file="$1"
266268
local old_version="$2"
@@ -271,11 +273,14 @@ update_internal_deps() {
271273
escaped_old_version=$(printf '%s' "${old_version}" | sed 's/\./\\./g')
272274

273275
for pack_name in "${INTERNAL_PACKS[@]}"; do
274-
# Update quoted caret-prefixed versions: "^X.Y.Z"
275-
sed -i.bak "s|${pack_name}: \"\\^${escaped_old_version}\"|${pack_name}: \"^${new_version}\"|g" "${file}"
276+
# Update quoted caret-prefixed versions: "^X.Y.Z" (pack name optionally quoted)
277+
sed -i.bak "s|\"\\{0,1\\}${pack_name}\"\\{0,1\\}: \"\\^${escaped_old_version}\"|${pack_name}: \"^${new_version}\"|g" "${file}"
276278
rm -f "${file}.bak"
277-
# Update unquoted exact versions: X.Y.Z
278-
sed -i.bak "s|${pack_name}: ${escaped_old_version}$|${pack_name}: ${new_version}|g" "${file}"
279+
# Update quoted exact versions: "X.Y.Z" (pack name optionally quoted)
280+
sed -i.bak "s|\"\\{0,1\\}${pack_name}\"\\{0,1\\}: \"${escaped_old_version}\"|${pack_name}: \"${new_version}\"|g" "${file}"
281+
rm -f "${file}.bak"
282+
# Update unquoted exact versions: X.Y.Z (pack name optionally quoted)
283+
sed -i.bak "s|\"\\{0,1\\}${pack_name}\"\\{0,1\\}: ${escaped_old_version}$|${pack_name}: ${new_version}|g" "${file}"
279284
rm -f "${file}.bak"
280285
done
281286
}

0 commit comments

Comments
 (0)