Adds test for separate control implementation

mbaluda · mbaluda · commit 521565e862cf · 2026-03-12T22:10:46.000+01:00
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/UI5Xss.expected b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/UI5Xss.expected
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/UI5Xss.qlref b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/UI5Xss.qlref
@@ -0,0 +1 @@
+UI5Xss/UI5Xss.ql
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/package-lock.json b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/package-lock.json
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/package.json b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/package.json
@@ -0,0 +1,5 @@
+{
+  "name": "sap-ui5-xss",
+  "version": "1.0.0",
+  "main": "index.js"
+}
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/ui5.yaml b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/ui5.yaml
@@ -0,0 +1,7 @@
+specVersion: '3.0'
+metadata:
+  name: sap-ui5-xss
+type: application
+framework:
+  name: SAPUI5
+  version: "1.115.0"
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/control/xss.js b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/control/xss.js
@@ -0,0 +1,21 @@
+sap.ui.define([
+    "sap/ui/core/Control"
+], function (Control) {
+    return Control.extend("codeql-sap-js.control.xss", {
+        metadata: {
+            properties: {
+                text: { type: "string" },
+                text2: { type: "string" }
+            }
+        },
+        renderer: {
+            apiVersion: 2,
+            render: function (oRm, oControl) {
+                oRm.openStart("div", oControl);
+                oRm.unsafeHtml(oControl.getText()); // XSS sink RenderManager.unsafeHtml
+                oRm.unsafeHtml(oControl.getText2()); // XSS sink RenderManager.unsafeHtml
+                oRm.close("div");
+            }
+        }
+    });
+})
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/controller/app.controller.js b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/controller/app.controller.js
@@ -0,0 +1,15 @@
+sap.ui.define([
+    "sap/ui/core/mvc/Controller",
+    "sap/ui/model/json/JSONModel"
+], function (Controller, JSONModel) {
+    "use strict"
+    return Controller.extend("codeql-sap-js.controller.app", {
+        onInit: function () {
+            var oData = {
+                input: null
+            };
+            var oModel = new JSONModel(oData);
+            this.getView().setModel(oModel);
+        }
+    });
+})
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/index.html b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/index.html
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<html>
+
+<head>
+
+    <meta charset="utf-8">
+    <title>SAPUI5 XSS</title>
+    <script src="https://sdk.openui5.org/resources/sap-ui-core.js" 
+        data-sap-ui-libs="sap.m"
+        data-sap-ui-onInit="module:codeql-sap-js/index" 
+        data-sap-ui-resourceroots='{
+            "codeql-sap-js": "./"
+        }'>
+        </script>
+</head>
+
+<body class="sapUiBody" id="content">
+
+</body>
+
+</html>
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/index.js b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/index.js
@@ -0,0 +1,11 @@
+sap.ui.define([
+    "sap/ui/core/mvc/XMLView"
+], function (XMLView) {
+    "use strict";
+    XMLView.create({
+        viewName: "codeql-sap-js.view.app"
+    }).then(function (oView) {
+        oView.placeAt("content");
+    });
+
+}); 
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/manifest.json b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/manifest.json
@@ -0,0 +1,5 @@
+{
+    "sap.app": {
+        "id": "sap-ui5-xss"
+    }
+}
diff --git a/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/view/app.view.xml b/javascript/frameworks/ui5/test/queries/UI5Xss/xss-custom-control-api3/webapp/view/app.view.xml
@@ -0,0 +1,9 @@
+<mvc:View controllerName="codeql-sap-js.controller.app"
+    xmlns="sap.m"
+    xmlns:mvc="sap.ui.core.mvc"
+    xmlns:xssControl="codeql-sap-js.control">
+    <Input placeholder="Enter Payload" 
+        description="Try: &lt;img src=x onerror=alert(&quot;XSS&quot;)&gt;" 
+        value="{/input}" />  <!--User input source sap.m.Input.value -->
+    <xssControl:xss text="{/input}"/>
+</mvc:View>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +{
 +    "sap.app": {
 +        "id": "sap-ui5-xss"
 +    }
 +}