Add upgrade-packs.sh script & address PR review

This commit:

- adds the scripts/upgrade-packs.sh script to provide a standard
  script for a common repo maintenance task;
- updates the update-codeql.yml actions workflow in order to:
  - address PR review comments;
  - run the new upgrade-packs.sh script as a step in the workflow.

Author: data-douser

.github/workflows/update-codeql.yml

@@ -108,7 +108,6 @@ jobs:
         run: |
           LATEST="${{ needs.detect-update.outputs.latest_version }}"
           echo "Updating all version-bearing files to ${LATEST}..."
-          chmod +x ./scripts/update-release-version.sh
           ./scripts/update-release-version.sh "${LATEST}"
 
       - name: Update - Install CodeQL via GitHub CLI
@@ -128,17 +127,7 @@ jobs:
           echo "CodeQL version: $(codeql version --format=terse)"
 
       - name: Update - Upgrade CodeQL pack lock files
-        shell: bash
-        run: |
-          echo "Upgrading CodeQL pack lock files..."
-          find . -name "qlpack.yml" -type f | sort | while read -r qlpack_file; do
-            pack_dir=$(dirname "$qlpack_file")
-            echo "Upgrading pack in directory: $pack_dir"
-            cd "$pack_dir"
-            codeql pack upgrade
-            cd - > /dev/null
-          done
-          echo "Finished upgrading all CodeQL pack lock files"
+        run: ./scripts/upgrade-packs.sh
 
       - name: Update - Setup Node.js for CDS compilation
         uses: actions/setup-node@v6
@@ -148,9 +137,7 @@ jobs:
           cache-dependency-path: 'extractors/cds/tools/package-lock.json'
 
       - name: Update - Compile CAP CDS files
-        run: |
-          chmod +x ./extractors/cds/tools/workflow/cds-compilation-for-actions.sh
-          ./extractors/cds/tools/workflow/cds-compilation-for-actions.sh
+        run: ./extractors/cds/tools/workflow/cds-compilation-for-actions.sh
 
       - name: Update - Run CodeQL unit tests
         env:

scripts/upgrade-packs.sh

@@ -0,0 +1,126 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+## upgrade-packs.sh
+## Upgrade CodeQL pack dependencies for packs in the codeql-sap-js repository.
+##
+## This script upgrades lock files for both source and test packs, installing
+## the latest compatible version of each dependency (ignoring existing lock files).
+##
+## Usage:
+##   ./scripts/upgrade-packs.sh
+##   ./scripts/upgrade-packs.sh --framework cap
+##   ./scripts/upgrade-packs.sh --framework ui5
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+REPO_ROOT="$(cd "${SCRIPT_DIR}/.." && pwd)"
+
+FRAMEWORK=""
+
+usage() {
+  cat <<EOF
+Usage: $0 [OPTIONS]
+
+Upgrade CodeQL pack dependencies for all packs in the repository.
+
+OPTIONS:
+    --framework <name>  Upgrade packs only for the specified framework
+                        Valid values: cap, heuristic-models, ui5, ui5-webcomponents, xsjs
+    -h, --help          Show this help message
+
+By default, the script upgrades packs for all frameworks.
+EOF
+}
+
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    --framework)
+      if [[ $# -lt 2 || "${2-}" == -* ]]; then
+        echo "Error: --framework requires a value" >&2
+        usage >&2
+        exit 1
+      fi
+      FRAMEWORK="$2"
+      shift 2
+      ;;
+    -h|--help)
+      usage
+      exit 0
+      ;;
+    *)
+      echo "Error: Unknown option $1" >&2
+      usage >&2
+      exit 1
+      ;;
+  esac
+done
+
+## Validate framework if provided
+VALID_FRAMEWORKS=("cap" "heuristic-models" "ui5" "ui5-webcomponents" "xsjs")
+if [[ -n "${FRAMEWORK}" ]]; then
+  FRAMEWORK_VALID=false
+  for valid_fw in "${VALID_FRAMEWORKS[@]}"; do
+    if [[ "${FRAMEWORK}" == "${valid_fw}" ]]; then
+      FRAMEWORK_VALID=true
+      break
+    fi
+  done
+
+  if [[ "${FRAMEWORK_VALID}" == false ]]; then
+    echo "Error: Invalid framework '${FRAMEWORK}'" >&2
+    echo "Valid frameworks: ${VALID_FRAMEWORKS[*]}" >&2
+    exit 1
+  fi
+fi
+
+cd "${REPO_ROOT}"
+
+## Upgrade a single pack given its qlpack.yml directory
+upgrade_pack() {
+  local pack_dir="$1"
+  if [[ -d "${pack_dir}" ]]; then
+    echo "INFO: Running 'codeql pack upgrade' for '${pack_dir}'..."
+    codeql pack upgrade -- "${pack_dir}"
+  else
+    echo "WARNING: Directory '${pack_dir}' not found, skipping" >&2
+  fi
+}
+
+## Upgrade packs for a framework (all subdirectories that contain qlpack.yml)
+upgrade_framework() {
+  local framework_path="$1"
+  echo "Upgrading packs for: ${framework_path}"
+
+  # Find all qlpack.yml files under this framework and upgrade their packs
+  find "${REPO_ROOT}/${framework_path}" -name "qlpack.yml" -type f | sort | while read -r qlpack_file; do
+    local pack_dir
+    pack_dir=$(dirname "${qlpack_file}")
+    # Use relative path for cleaner output
+    local rel_path="${pack_dir#${REPO_ROOT}/}"
+    upgrade_pack "${rel_path}"
+  done
+}
+
+if [[ -n "${FRAMEWORK}" ]]; then
+  case "${FRAMEWORK}" in
+    heuristic-models)
+      upgrade_framework "javascript/heuristic-models"
+      ;;
+    ui5-webcomponents)
+      upgrade_framework "javascript/frameworks/ui5-webcomponents"
+      ;;
+    *)
+      upgrade_framework "javascript/frameworks/${FRAMEWORK}"
+      ;;
+  esac
+else
+  echo "Upgrading packs for all frameworks..."
+  upgrade_framework "javascript/frameworks/cap"
+  upgrade_framework "javascript/frameworks/ui5"
+  upgrade_framework "javascript/frameworks/ui5-webcomponents"
+  upgrade_framework "javascript/frameworks/xsjs"
+  upgrade_framework "javascript/heuristic-models"
+fi
+
+echo ""
+echo "✅ All CodeQL pack lock files upgraded successfully."