Skip to content

Commit 70f89a3

Browse files
Copilotdata-douser
andcommitted
Fix review feedback: yamllint config path, agent structure diagram, and UI5 prompt outer fences (#336)
* Initial plan * Address review feedback: fix yamllint commands, agent structure diagram, and UI5 prompt fences Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com> Agent-Logs-Url: https://github.com/advanced-security/codeql-sap-js/sessions/404b2862-c982-4730-894b-d434ad2bb1ed --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: data-douser <70299490+data-douser@users.noreply.github.com>
1 parent e1b245d commit 70f89a3

File tree

5 files changed

+3
-14
lines changed

5 files changed

+3
-14
lines changed

.github/agents/github-maintenance-agent.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ My `github-maintenance-agent`:
2727
Validate GitHub Actions workflows:
2828
```bash
2929
# Check YAML syntax
30-
yamllint .github/workflows/*.yml
30+
yamllint -c .github/.yamllint .github/workflows/*.yml
3131
```
3232

3333
Test issue template rendering:
@@ -41,12 +41,7 @@ gh issue create --web
4141
```
4242
.github/
4343
├── agents/ # Agent definitions
44-
│ ├── cds-extractor-agent.md
45-
│ ├── cap-modeling-agent.md
46-
│ ├── ui5-modeling-agent.md
47-
│ ├── xsjs-modeling-agent.md
48-
│ ├── dependency-upgrade-agent.md
49-
│ └── github-maintenance-agent.md
44+
│ └── *.md # Individual agent definition files
5045
├── instructions/ # Middle-layer instructions
5146
│ ├── extractors_cds_tools_ts.instructions.md
5247
│ ├── javascript_cap_ql.instructions.md

.github/prompts/github_maintenance.prompt.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ When updating `.github/workflows/*.yml`:
122122
actionlint .github/workflows/*.yml
123123
124124
# Or use yamllint
125-
yamllint .github/workflows/*.yml
125+
yamllint -c .github/.yamllint .github/workflows/*.yml
126126
127127
# Test in PR before merging
128128
```

.github/prompts/ui5_framework_codeql_dev.prompt.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
```prompt
21
# UI5 Framework CodeQL Query Development
32

43
Guidelines for developing CodeQL security queries that detect vulnerable code patterns in SAPUI5 applications.
@@ -165,4 +164,3 @@ const fragment = await Fragment.load({
165164
- [UI5 Library Modeling Prompt](ui5_framework_codeql_lib.prompt.md) - Library implementation details
166165
- [UI5 Testing Prompt](ui5_framework_codeql_test.prompt.md) - Test case development
167166
- [CodeQL Test Commands](codeql_test_commands.prompt.md) - Testing workflow
168-
```

.github/prompts/ui5_framework_codeql_lib.prompt.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
```prompt
21
# UI5 Framework CodeQL Library Modeling
32

43
Guidelines for developing CodeQL library models (`.qll` files) that define sources, sinks, and taint steps for SAPUI5 security analysis.
@@ -264,4 +263,3 @@ module UI5LogInjection implements DataFlow::ConfigSig {
264263
- [UI5 Query Development Prompt](ui5_framework_codeql_dev.prompt.md) - Query file structure
265264
- [UI5 Testing Prompt](ui5_framework_codeql_test.prompt.md) - Test case development
266265
- [UI5 Framework Development](ui5_framework_development.prompt.md) - General UI5 context
267-
```

.github/prompts/ui5_framework_codeql_test.prompt.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
```prompt
21
# UI5 Framework CodeQL Unit Testing
32

43
Guidelines for creating unit tests for UI5 CodeQL queries and library models.
@@ -287,4 +286,3 @@ Each alert on separate line in `#select`:
287286
- [UI5 Library Modeling Prompt](ui5_framework_codeql_lib.prompt.md) - Library implementation
288287
- [CodeQL Test Commands](codeql_test_commands.prompt.md) - Command reference
289288
- [Test-Driven Development](test_driven_development.prompt.md) - TDD workflow
290-
```

0 commit comments

Comments
 (0)