Fix CDS extractor cds-indexer deps

Attempt to fix the CDS extractor's support for
private "cds-indexer" package installation by
ensuring that the associated project's entire
node_modules directory is copied instead of just
the cachable subset of the CAP projects NodeJS
dependencies.

Author: data-douser

extractors/cds/tools/src/cds/indexer.ts

@@ -5,6 +5,7 @@ import { delimiter, join } from 'path';
 
 import { addCdsIndexerDiagnostic } from '../diagnostics';
 import { cdsExtractorLog } from '../logging';
+import { projectInstallDependencies } from '../packageManager';
 import type { CdsDependencyGraph, CdsProject } from './parser/types';
 
 /** Maximum time (ms) allowed for a single cds-indexer invocation. */
@@ -199,6 +200,19 @@ export function orchestrateCdsIndexer(
 
     if (result.success) {
       summary.successfulRuns++;
+
+      // Install the project's full dependencies so the CDS compiler can
+      // resolve all CDS model imports (e.g. `@sap/cds-shim`) during
+      // compilation.  The cache directory only contains `@sap/cds`,
+      // `@sap/cds-dk`, and `@sap/cds-indexer`, which is not enough for
+      // projects that reference additional CDS packages.
+      const installResult = projectInstallDependencies(project, sourceRoot);
+      if (!installResult.success) {
+        cdsExtractorLog(
+          'warn',
+          `Full dependency installation failed for project '${projectDir}' after successful cds-indexer run: ${installResult.error ?? 'unknown error'}`,
+        );
+      }
     } else {
       summary.failedRuns++;
 

extractors/cds/tools/test/src/cds/indexer.test.ts

@@ -6,6 +6,7 @@ import {
   runCdsIndexer,
 } from '../../../src/cds/indexer';
 import { CdsDependencyGraph, CdsProject, PackageJson } from '../../../src/cds/parser/types';
+import * as projectInstaller from '../../../src/packageManager/projectInstaller';
 
 // Mock dependencies
 jest.mock('child_process', () => ({
@@ -27,6 +28,17 @@ jest.mock('../../../src/diagnostics', () => ({
   },
 }));
 
+jest.mock('../../../src/packageManager/projectInstaller', () => ({
+  projectInstallDependencies: jest.fn().mockReturnValue({
+    success: true,
+    projectDir: '/source/myProject',
+    warnings: [],
+    durationMs: 1000,
+    timedOut: false,
+  }),
+  needsFullDependencyInstallation: jest.fn().mockReturnValue(false),
+}));
+
 // Helper to create a minimal CdsProject mock
 function createMockProject(projectDir: string, packageJson?: PackageJson): CdsProject {
   return {
@@ -481,5 +493,98 @@ describe('cds/indexer', () => {
         }),
       );
     });
+
+    it('should install full project dependencies after successful cds-indexer run', () => {
+      (childProcess.spawnSync as jest.Mock).mockReturnValue({
+        status: 0,
+        stdout: Buffer.from(''),
+        stderr: Buffer.from(''),
+        error: undefined,
+      });
+
+      const project = createMockProject('myProject', {
+        name: 'my-cap-app',
+        dependencies: {
+          '@sap/cds': '^7.0.0',
+          '@sap/cds-indexer': '^1.0.0',
+        },
+      });
+      const graph = createMockDependencyGraph([project]);
+
+      orchestrateCdsIndexer(graph, '/source', new Map());
+
+      expect(projectInstaller.projectInstallDependencies).toHaveBeenCalledWith(
+        project,
+        '/source',
+      );
+    });
+
+    it('should not install full project dependencies when cds-indexer fails', () => {
+      (childProcess.spawnSync as jest.Mock).mockReturnValue({
+        status: 1,
+        stdout: Buffer.from(''),
+        stderr: Buffer.from('indexer error'),
+        error: undefined,
+      });
+
+      const project = createMockProject('myProject', {
+        name: 'my-cap-app',
+        dependencies: {
+          '@sap/cds': '^7.0.0',
+          '@sap/cds-indexer': '^1.0.0',
+        },
+      });
+      const graph = createMockDependencyGraph([project]);
+
+      orchestrateCdsIndexer(graph, '/source', new Map());
+
+      expect(projectInstaller.projectInstallDependencies).not.toHaveBeenCalled();
+    });
+
+    it('should not install full project dependencies for projects without cds-indexer', () => {
+      const project = createMockProject('myProject', {
+        name: 'my-cap-app',
+        dependencies: { '@sap/cds': '^7.0.0' },
+      });
+      const graph = createMockDependencyGraph([project]);
+
+      orchestrateCdsIndexer(graph, '/source', new Map());
+
+      expect(projectInstaller.projectInstallDependencies).not.toHaveBeenCalled();
+    });
+
+    it('should continue even when full dependency installation fails after indexer success', () => {
+      (childProcess.spawnSync as jest.Mock).mockReturnValue({
+        status: 0,
+        stdout: Buffer.from(''),
+        stderr: Buffer.from(''),
+        error: undefined,
+      });
+
+      (projectInstaller.projectInstallDependencies as jest.Mock).mockReturnValue({
+        success: false,
+        projectDir: '/source/myProject',
+        warnings: ['npm install failed'],
+        durationMs: 500,
+        timedOut: false,
+        error: 'npm install failed',
+      });
+
+      const project = createMockProject('myProject', {
+        name: 'my-cap-app',
+        dependencies: {
+          '@sap/cds': '^7.0.0',
+          '@sap/cds-indexer': '^1.0.0',
+        },
+      });
+      const graph = createMockDependencyGraph([project]);
+
+      const summary = orchestrateCdsIndexer(graph, '/source', new Map());
+
+      // Indexer itself succeeded; dependency install failure is non-fatal
+      expect(summary.successfulRuns).toBe(1);
+      expect(summary.failedRuns).toBe(0);
+      expect(projectInstaller.projectInstallDependencies).toHaveBeenCalled();
+    });
   });
 });