Skip to content

Commit 86dfa41

Browse files
committed
Fix overlay[local] errors for CodeQL 2.24.0 upgrade
Add overlay[local?] annotations to classes that extend overlay-annotated classes from the standard library to comply with stricter overlay annotation enforcement in CodeQL 2.24.0: - UI5.qll: Add overlay[local?] to UserModule and SapDefineModule classes that extend AmdModuleDefinition::Range - AsyncXSJS.qll: Add overlay[local?] to XSJSDollarNamespace class that is referenced through TypeModel This fixes compilation errors like: 'Declaration is annotated overlay[local] but depends on global entity'
1 parent eb8c2d3 commit 86dfa41

2 files changed

Lines changed: 3 additions & 0 deletions

File tree

  • javascript/frameworks
    • ui5/lib/advanced_security/javascript/frameworks/ui5
    • xsjs/lib/advanced_security/javascript/frameworks/xsjs

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -171,6 +171,7 @@ class FragmentModule extends DataFlow::SourceNode {
171171
/**
172172
* A user-defined module through `sap.ui.define` or `jQuery.sap.declare`.
173173
*/
174+
overlay[local?]
174175
abstract class UserModule extends CallExpr {
175176
abstract string getADependency();
176177

@@ -183,6 +184,7 @@ abstract class UserModule extends CallExpr {
183184
* A user-defined module through `sap.ui.define`.
184185
* https://sapui5.hana.ondemand.com/sdk/#/api/sap.ui%23methods/sap.ui.define
185186
*/
187+
overlay[local?]
186188
class SapDefineModule extends AmdModuleDefinition::Range, MethodCallExpr, UserModule {
187189
SapDefineModule() {
188190
/*

javascript/frameworks/xsjs/lib/advanced_security/javascript/frameworks/xsjs/AsyncXSJS.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import DataFlow
44
/**
55
* The root XSJS namespace, accessed as a dollar sign (`$`) symbol.
66
*/
7+
overlay[local?]
78
class XSJSDollarNamespace extends GlobalVarRefNode {
89
XSJSDollarNamespace() {
910
this = globalVarRef("$") and

0 commit comments

Comments
 (0)