Introduce hierarchy on control-related API calls

Author: jeongsoolee09

javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/RemoteFlowSources.qll

@@ -4,34 +4,41 @@ import advanced_security.javascript.frameworks.ui5.UI5View
 import semmle.javascript.security.dataflow.XssThroughDomCustomizations
 private import semmle.javascript.frameworks.data.internal.ApiGraphModelsExtensions
 
-private class DataFromRemoteControlReference extends RemoteFlowSource {
-  DataFromRemoteControlReference() {
-    exists(UI5Control sourceControl, string typeAlias, ControlReference controlReference |
+abstract private class RemoteControlAPISource extends SourceNode { }
+
+private class RemoteControlReference extends RemoteControlAPISource, ControlReference {
+  RemoteControlReference() {
+    exists(UI5Control sourceControl, string typeAlias |
       typeModel(typeAlias, sourceControl.getImportPath(), _) and
       sourceModel(typeAlias, _, "remote", _) and
-      sourceControl.getAReference() = controlReference and
-      (
-        this = controlReference.getAMemberCall("getValue") or
-        this = controlReference.getAMemberCall("getCurrentValue") or
-        this = controlReference.getAPropertyRead("value")
-      )
+      sourceControl.getAReference() = this
     )
   }
-
-  override string getSourceType() { result = "Data from a remote control" }
 }
 
-private class UI5ControlHandlerParameter extends RemoteFlowSource {
-  UI5ControlHandlerParameter() {
+private class RemoteControlHandlerParameter extends RemoteControlAPISource, CallNode {
+  RemoteControlHandlerParameter() {
     exists(UI5Control sourceControl, string typeAlias, UI5Handler handler |
       typeModel(typeAlias, sourceControl.getImportPath(), _) and
       sourceModel(typeAlias, _, "remote", _) and
       handler.getControl() = sourceControl and
-      this = handler.getParameter(0).getAMemberCall("getSource").getAMemberCall("getValue")
+      this = handler.getParameter(0).getAMemberCall("getSource")
+    )
+  }
+}
+
+private class UserDataFromRemoteControlAPISource extends RemoteFlowSource {
+  UserDataFromRemoteControlAPISource() {
+    exists(RemoteControlAPISource remoteControlAPISource |
+      this = remoteControlAPISource.getAMemberCall("getValue") or
+      this = remoteControlAPISource.getAMemberCall("getCurrentValue") or
+      this = remoteControlAPISource.getAPropertyRead("value")
     )
   }
 
-  override string getSourceType() { result = "Event parameter of a remote control" }
+  override string getSourceType() {
+    result = "User-provided data fetched from an input control via JavaScript API"
+  }
 }
 
 private class InputControlInstantiation extends ElementInstantiation {