Fix getModelReference/0 and getModelReference/1

jeongsoolee09 · jeongsoolee09 · commit dec0ab903f8f · 2025-10-01T14:14:07.000-04:00
diff --git a/javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll b/javascript/frameworks/ui5/lib/advanced_security/javascript/frameworks/ui5/UI5.qll
@@ -495,12 +495,11 @@ class CustomController extends SapExtendCall {
   }
 
   ModelReference getModelReference(string modelName) {
-    result = this.getAViewReference().getAMemberCall(modelName)
+    result = this.getAViewReference().getAMemberCall("getModel") and
+    result.getArgument(0).getALocalSource().getStringValue() = modelName
   }
 
-  ModelReference getAModelReference() {
-    result = this.getAViewReference().getAMemberCall("getModel")
-  }
+  ModelReference getAModelReference() { result = this.getModelReference(_) }
 
   RouterReference getARouterReference() {
     exists(ThisNode controllerThis | controllerThis.getBinder() = this.getAMethod() |

Original file line number	Diff line number	Diff line change
`@@ -495,12 +495,11 @@ class CustomController extends SapExtendCall {`
`495`	`495`	`}`
`496`	`496`
`497`	`497`	`ModelReference getModelReference(string modelName) {`
`498`		`- result = this.getAViewReference().getAMemberCall(modelName)`
	`498`	`+ result = this.getAViewReference().getAMemberCall("getModel") and`
	`499`	`+ result.getArgument(0).getALocalSource().getStringValue() = modelName`
`499`	`500`	`}`
`500`	`501`
`501`		`- ModelReference getAModelReference() {`
`502`		`- result = this.getAViewReference().getAMemberCall("getModel")`
`503`		`- }`
	`502`	`+ ModelReference getAModelReference() { result = this.getModelReference(_) }`
`504`	`503`
`505`	`504`	`RouterReference getARouterReference() {`
`506`	`505`	`exists(ThisNode controllerThis \| controllerThis.getBinder() = this.getAMethod() \|`