Automatically migrate log4j xml from 4.19 to 4.20+

[yadvr]

• Allow automatic migration of log4j xml when upgrading from 4.19 or older versions to 4.20 or later versions; during upgrade keep the old log4j xml as .backup (or .old) file instead of overwriting it.
• apilog.log file is empty now, any UI/API activities don't add new lines to it anymore - also at: API logs not generated in 4.20 #10565
• null folder created for no reason at /var/log/cloudstack/management:

└── null
    └── template
        └── n
            └── null

cc @Pearl1594 @DaanHoogland @JoaoJandre @GutoVeronezi

[weizhouapache]

the issue 2 is same as #10565

apilog.log file is empty now, any UI/API activities don't add new lines to it anymore

confirmed issue 3

[DaanHoogland]

As @weizhouapache remarked, the logging issue itself is addressed in #10567
That leaves the question if we should save the old logging configuration or consider this responsibility to lie with the package manager. Any remaining issues?

[JoaoJandre]

@rohityadavcloud @weizhouapache, I have not been able to confirm issue 3 in 4.20. Thus this must have been introduced in another PR (not related to the log4j2 upgrade).

Regarding issue 1, I was under the impression that it was left as a responsibility of the package manager. I've had no issues with apt after multiple upgrades.

[Pearl1594]

I upgraded from 4.19.0 to 4.20.0 - and I didn't encounter the 3rd issue mentioned as well.

[weizhouapache]

I upgraded from 4.19.0 to 4.20.0 - and I didn't encounter the 3rd issue mentioned as well.

the folder /var/log/cloudstack/management/null/ does exist in my old testing env.
created on 2024-09-26 23:10:29.226545537 +0000

anyway, a trivial issue we can ignore for now

[yadvr]

Can we at least look at the first issue (Allow automatic migration of log4j xml when upgrading from 4.19 or older versions to 4.20 or later versions; during upgrade keep the old log4j xml as .backup (or .old) file instead of overwriting it) for both deb & rpm pkgs?

[nvazquez]

Hi @weizhouapache @Pearl1594 is there any update regarding the first issue?