Merge pull request #12 from Voyz/fix/data-news-on-init

areed1192 · web-flow · commit 5dba9c8e9866 · 2020-10-23T12:55:48.000-07:00
don't assume data_news() will return a valid dict
diff --git a/ibw/client.py b/ibw/client.py
@@ -199,7 +199,8 @@ def _set_server(self) -> bool:
         )
 
         # TO DO: Add check market hours here and then check for a mutual fund.
-        if 'news' in self.data_news(conid='265598'):
+        news = self.data_news(conid='265598')
+        if news and 'news' in news:
             print(success)
             return True
         if server_account_content is not None and 'set' in server_update_content.keys() and server_update_content['set'] == True:

Original file line number	Diff line number	Diff line change
`@@ -199,7 +199,8 @@ def _set_server(self) -> bool:`
`199`	`199`	`)`
`200`	`200`
`201`	`201`	`# TO DO: Add check market hours here and then check for a mutual fund.`
`202`		`- if 'news' in self.data_news(conid='265598'):`
	`202`	`+ news = self.data_news(conid='265598')`
	`203`	`+ if news and 'news' in news:`
`203`	`204`	`print(success)`
`204`	`205`	`return True`
`205`	`206`	`if server_account_content is not None and 'set' in server_update_content.keys() and server_update_content['set'] == True:`