add price history fix

Author: areed1192

.gitignore

@@ -117,3 +117,5 @@ pypirc
 tests/parse_level_two.py
 certs/
 td/td_state.json
+tests/api_pipeline.py
+tests/api_streaming.py

samples/api_streaming.py

@@ -4,123 +4,123 @@
 from datetime import timedelta
 from td.client import TDClient
 
-# Create a new session
+# Create a new session.
 TDSession = TDClient(
     client_id='<CLIENT_ID>',
     redirect_uri='<REDIRECT_URI>',
     credentials_path='<CREDENTIALS_PATH>'
 )
 
-# Login to the session
+# Login to the session.
 TDSession.login()
 
-# Create a streaming session
+# Create a streaming session.
 TDStreamingClient = TDSession.create_streaming_session()
 
-# Set the data dump location
+# Set the data dump location.
 TDStreamingClient.write_behavior(
     write='csv',
     file_path=r"../td-ameritrade-python-api/samples/raw_data.csv",
     append_mode=True
 )
 
-# Account Activity
+# Account Activity.
 TDStreamingClient.account_activity()
 
-# Actives
+# Actives.
 TDStreamingClient.actives(
     service='ACTIVES_NASDAQ',
     venue='NASDAQ',
     duration='ALL'
 )
 
-# Quality of Service
+# Quality of Service.
 TDStreamingClient.quality_of_service(qos_level='express')
 
-# Level One Quote
+# Level One - Quote.
 TDStreamingClient.level_one_quotes(
     symbols=["SPY", "IVV", "SDS"],
     fields=list(range(0, 50))
 )
 
-# Level One Option
+# Level One - Option.
 TDStreamingClient.level_one_options(
     symbols=['AAPL_040920C115'],
     fields=list(range(0, 42))
 )
 
-# Level One Futures
+# Level One - Futures.
 TDStreamingClient.level_one_futures(
     symbols=['/CL'],
     fields=list(range(0, 34))
 )
 
-# Level One Forex
+# Level One - Forex.
 TDStreamingClient.level_one_forex(
     symbols=['EUR/USD'],
     fields=list(range(0, 20))
 )
 
-# Level One Futures Options
+# Level One - Futures Options.
 TDStreamingClient.level_one_futures_options(
     symbols=['./EW2J20C2675'],
     fields=list(range(0, 36))
 )
 
-# Charts Futures
+# Charts - Futures.
 TDStreamingClient.chart(
     service='CHART_EQUITY',
     symbols=['AAPL', 'MSFT'],
     fields=[0, 1, 2, 3, 4, 5, 6, 7]
 )
 
-# Chart History Futures
+# Chart History - Futures.
 TDStreamingClient.chart_history_futures(
     symbol=['/ES'],
     frequency='m1',
     start_time='1586304000000',
     end_time='1586329200000'
 )
 
-# Timesale - Equity
+# Timesale - Equity.
 TDStreamingClient.timesale(
     service='TIMESALE_EQUITY',
     symbols=['AAPL'],
     fields=[0, 1, 2, 3, 4]
 )
 
-# Timesale - Futures
+# Timesale - Futures.
 TDStreamingClient.timesale(
     service='TIMESALE_FUTURES',
     symbols=['/ES'],
     fields=[0, 1, 2, 3, 4]
 )
 
-# News Headline
+# News Headline.
 TDStreamingClient.news_headline(
     symbols=['AAPL', 'SPY'],
     fields=[0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
 )
 
-# Level Two Quotes
+# Level Two - Quotes.
 TDStreamingClient.level_two_quotes(
     symbols=['IBM'],
     fields=[0, 1, 2]
 )
 
-# Level Two Options
+# Level Two - Options.
 TDStreamingClient.level_two_options(
     symbols=['AAPL_040920C115'],
     fields=[0, 1, 2]
 )
 
-# Level Two NASQDAQ
+# Level Two - NASQDAQ.
 TDStreamingClient.level_two_nasdaq(
     symbols=['MSFT'],
     fields=[0, 1, 2]
 )
 
-# Level Two Total View
+# Level Two - Total View.
 TDStreamingClient.level_two_total_view(
     symbols=['AAPL'],
     fields=['0', '1', '2']

td/client.py

@@ -115,7 +115,7 @@ def __init__(self, client_id: str, redirect_uri: str, account_number: str = None
         else:
             self._flask_app = None
 
-        # define a new attribute called 'authstate' and initalize it to '' (Blank). This will be used by our login function.
+        # define a new attribute called 'authstate' and initialize to `False`. This will be used by our login function.
         self.authstate = False
 
         # call the state_manager method and update the state to init (initalized)
@@ -702,7 +702,7 @@ def get_quotes(self, instruments: List) -> Dict:
         # return the response of the get request.
         return self._make_request(method='get', endpoint=endpoint, params=params)
 
-    def get_price_history(self, symbol: str, period_type:str = None, period=None, start_date:str = None, end_date:str = None,
+    def get_price_history(self, symbol: str, period_type:str = None, period: str = None, start_date:str = None, end_date:str = None,
                           frequency_type: str = None, frequency: str = None, extended_hours: bool = True) -> Dict:
         """Gets historical candle data for a financial instrument.
         
@@ -748,14 +748,14 @@ def get_price_history(self, symbol: str, period_type:str = None, period=None, st
             try:
 
                 # check if the period is valid.
-                if period in VALID_CHART_VALUES[frequency_type][period_type]:
+                if period in VALID_CHART_VALUES[frequency_type][int(period_type)]:
                     True
                 else:
                     raise IndexError('Invalid Period.')
             except:
                 raise KeyError('Invalid Frequency Type or Period Type you passed through is not valid')
 
-            if frequency_type == 'minute' and frequency not in [1, 5, 10, 15, 30]:
+            if frequency_type == 'minute' and frequency not in ['1', '5', '10', '15', '30']:
                 raise ValueError('Invalid Minute Frequency, must be 1,5,10,15,30')
 
         # build the params dictionary