From ad5e8e6bc84ee03ce97dd8be817d42c38b4b0d16 Mon Sep 17 00:00:00 2001
From: Ben Frederickson <ben@benfrederickson.com>
Date: Thu, 7 May 2026 10:34:09 -0700
Subject: [PATCH] Drop support for python 3.8

Python 3.8 is EOL since 2024, drop support for it
---
 .github/workflows/build.yml | 4 ++--
 implicit/gpu/matrix.pxd     | 2 +-
 pyproject.toml              | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 0838ace2..6a9df37f 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -28,7 +28,7 @@ jobs:
     strategy:
       matrix:
         os: [macos-latest, ubuntu-latest, windows-latest, ubuntu-24.04-arm]
-        python-version: [38, 39, 310, 311, 312, 313, 314]
+        python-version: [39, 310, 311, 312, 313, 314]
 
     steps:
       - uses: actions/checkout@v6
@@ -60,7 +60,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        python-version: [3.8, 3.9, '3.10', '3.11', '3.12', '3.13', '3.14']
+        python-version: [3.9, '3.10', '3.11', '3.12', '3.13', '3.14']
         os: [macos-latest, ubuntu-latest, windows-latest, ubuntu-24.04-arm]
 
     steps:
diff --git a/implicit/gpu/matrix.pxd b/implicit/gpu/matrix.pxd
index 26cbfb2f..eafa537f 100644
--- a/implicit/gpu/matrix.pxd
+++ b/implicit/gpu/matrix.pxd
@@ -21,7 +21,7 @@ cdef extern from "implicit/gpu/matrix.h" namespace "implicit::gpu" nogil:
         Matrix(const Matrix & other, size_t rowid) except +
         Matrix(const Matrix & other, size_t start, size_t end) except +
         Matrix(const Matrix & other, const Vector[int] & rowids) except +
-        Matrix(Matrix && other) except +
+        Matrix(Matrix & other) except +
         void to_host(void * output) except +
         void resize(size_t rows, size_t cols) except +
         void assign_rows(const Vector[int] & rowids, const Matrix & other) except +
diff --git a/pyproject.toml b/pyproject.toml
index 8f7401ae..ef25c230 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -16,7 +16,7 @@ readme = "README.md"
 authors = [
   { name = "Ben Frederickson", email = "ben@benfrederickson.com" },
 ]
-requires-python = ">=3.8"
+requires-python = ">=3.9"
 license = "MIT"
 license-files = ["LICENSE"]
 classifiers = [