Skip to content

Commit dcac4df

Browse files
Bhargavi-BSclaude
andcommitted
chore: remove ticket identifiers from code comments
Same review convention as requested on #1131. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 613a136 commit dcac4df

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

bin/helpers/archiver.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ const archiveSpecs = (runSettings, filePath, excludeFiles, md5data) => {
5858

5959
let ignoreFiles = utils.getFilesToIgnore(runSettings, excludeFiles);
6060
logger.debug(`Patterns ignored during zip ${ignoreFiles}`);
61-
// SDK-6463 (perf): `ignore` filters entries only AFTER the walk visits them, so the
61+
// Perf: `ignore` filters entries only AFTER the walk visits them, so the
6262
// globber still descends into node_modules/.git/etc. `skip` prunes those directories
6363
// from the traversal entirely — on large monorepos this cuts zip creation from
6464
// minutes to seconds without changing the archive contents.

bin/helpers/checkUploaded.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const checkSpecsMd5 = (runSettings, args, instrumentBlocks) => {
2525
let options = {
2626
cwd: cypressFolderPath,
2727
ignore: ignoreFiles,
28-
// SDK-6463 (perf): prune ignored directories from the md5 walk instead of
28+
// Perf: prune ignored directories from the md5 walk instead of
2929
// filtering entries after descending into them (see utils.getDirectorySkipPatterns).
3030
skip: utils.getDirectorySkipPatterns(ignoreFiles),
3131
pattern: `**/*.+(${Constants.allowedFileTypes.join("|")})`

bin/helpers/utils.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1103,7 +1103,7 @@ exports.getFilesToIgnore = (runSettings, excludeFiles, logging = true) => {
11031103
return ignoreFiles;
11041104
}
11051105

1106-
// SDK-6463 (perf): derive directory-pruning patterns from the ignore list.
1106+
// Perf: derive directory-pruning patterns from the ignore list.
11071107
// readdir-glob (used both by archiver.glob for tests.zip and by hashUtil for the
11081108
// spec md5 check) applies `ignore` per-entry AFTER walking, so it still descends
11091109
// into node_modules/.git/dist etc. On large monorepos that walk alone takes
@@ -1738,7 +1738,7 @@ exports.fetchZipSize = (fileName) => {
17381738

17391739
const getDirectorySize = async function(dir, deadline) {
17401740
try{
1741-
// SDK-6463 (perf): this telemetry-only walk recursively stats every file (it is
1741+
// Perf: this telemetry-only walk recursively stats every file (it is
17421742
// pointed at node_modules in runs.js). On large monorepos it blocked the pipeline
17431743
// between archiving and uploading for tens of seconds. Stop descending once the
17441744
// deadline passes — folder size is best-effort telemetry, never worth stalling a run.

test/unit/bin/helpers/utils.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -770,7 +770,7 @@ describe('utils', () => {
770770
});
771771
});
772772

773-
// SDK-6463 (perf): directory-shaped ignore patterns are reused as readdir-glob `skip`
773+
// Perf: directory-shaped ignore patterns are reused as readdir-glob `skip`
774774
// patterns so the zip/md5 walks prune excluded trees instead of descending into them.
775775
describe('getDirectorySkipPatterns', () => {
776776
it('keeps only patterns ending in /** (safe to prune)', () => {

0 commit comments

Comments
 (0)