Skip to content

CFE-4682: Fix memory leak in EvalContextHeapPersistentSave #6166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nickanderson wants to merge 1 commit into from
+3 −0
Closed

CFE-4682: Fix memory leak in EvalContextHeapPersistentSave #6166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libpromises/eval_context.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -748,6 +748,7 @@ void EvalContextHeapPersistentSave(EvalContext *ctx, const char *name, unsigned
Log(LOG_LEVEL_VERBOSE, "Persistent class '%s' is already in a preserved state -- %jd minutes to go",
key, (intmax_t)((existing_info->expires - now) / 60));
CloseDB(dbp);
free(existing_info);
free(key);
free(new_info);
return;
Expand All @@ -757,10 +758,12 @@ void EvalContextHeapPersistentSave(EvalContext *ctx, const char *name, unsigned
{
Log(LOG_LEVEL_ERR, "While persisting class '%s', error reading existing value", key);
CloseDB(dbp);
free(existing_info);
free(key);
free(new_info);
return;
}
free(existing_info);
}
}

Expand Down