Skip to content

refactor: use the #[\Override] attribute - #10778

Open
paulbalandan wants to merge 2 commits into
codeigniter4:4.8from
paulbalandan:override-attr
Open

paulbalandan wants to merge 2 commits into
codeigniter4:4.8from
paulbalandan:override-attr

Conversation

@paulbalandan

@paulbalandan paulbalandan commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Description
Adds the #[Override] attribute and enforced by PHPStan.

This change is mechanical:

  • Added checkMissingOverrideMethodAttribute: true to phpstan.dist.neon
  • Run composer phpstan:check -- --fix to auto fix.
  • Run composer cs-fix to import.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@carson-codeigniter4 carson-codeigniter4 Bot added 4.8 PRs that target the `4.8` branch. refactor Pull requests that refactor code labels Nov 18, 2026
@paulbalandan
paulbalandan force-pushed the override-attr branch 2 times, most recently from 730b688 to 15e2a7d Compare November 18, 2026 04:34
@paulbalandan

Copy link
Copy Markdown
Member Author

Applied the attribute to the docs samples too.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.8 PRs that target the `4.8` branch. refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants