CI-windows.yml: cleaned and sped up build_qt job

Author: firewave

.github/workflows/CI-windows.yml

@@ -21,7 +21,6 @@ defaults:
 
 jobs:
 
-  # TODO: use Debug build to speed it up?
   build_qt:
     strategy:
       matrix:
@@ -52,24 +51,22 @@ jobs:
       - name: Run CMake
         run: |
           rem TODO: enable rules?
-          rem specify Release build so matchcompiler is used
-          cmake -S . -B build -Werror=dev --warn-uninitialized -DCMAKE_BUILD_TYPE=Release -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DBUILD_TESTING=Off -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DBUILD_ONLINE_HELP=On -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
+          cmake -S . -B build -Werror=dev --warn-uninitialized -DCMAKE_BUILD_TYPE=Debug -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DBUILD_TESTING=Off -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DBUILD_ONLINE_HELP=On -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
 
       - name: Build GUI release
         run: |
-          cmake --build build --target cppcheck-gui --config Release || exit /b !errorlevel!
+          cmake --build build --config Debug --target cppcheck-gui || exit /b !errorlevel!
 
+      # TODO: is there a way to do this in CMake
       - name: Deploy GUI
         run: |
-          windeployqt build\bin\Release || exit /b !errorlevel!
-          del build\bin\Release\cppcheck-gui.ilk || exit /b !errorlevel!
-          del build\bin\Release\cppcheck-gui.pdb || exit /b !errorlevel!
+          windeployqt --no-translations build\bin\Debug || exit /b !errorlevel!
 
       # TODO: run GUI tests
 
       - name: Run CMake install
         run: |
-          rem TODO: this performs a Debug build
-          rem TODO: the Qt DLLS are not being installed (because of the missing windeployqt?)
-          cmake --build build --target install
+          rem TODO: the Qt DLLs are not being installed
+          cmake --build build --config Debug --target install
           rem TODO: validate the installed files
+          rem TODO: the structure does not match an actual Windows installation

cmake/findDependencies.cmake

@@ -26,6 +26,18 @@ if(BUILD_GUI)
             find_program(QHELPGENERATOR qhelpgenerator HINTS ${_qt_bin_dir} REQUIRED)
         endif()
     endif()
+
+    if(MSVC)
+        find_program(WINDEPLOYQT windeployqt)
+        if(NOT WINDEPLOYQT)
+            # TODO: how to properly get the Qt binary folder?
+            # piggy-back off Qt::qmake for now as it should be in the same folder as the binary we are looking for
+            get_target_property(_qmake_executable Qt::qmake IMPORTED_LOCATION)
+            get_filename_component(_qt_bin_dir ${_qmake_executable} DIRECTORY)
+            message(STATUS "windeployqt not found in PATH - trying ${_qt_bin_dir}")
+            find_program(WINDEPLOYQT windeployqt HINTS ${_qt_bin_dir} REQUIRED)
+        endif()
+    endif()
 endif()
 
 if(HAVE_RULES)

cmake/printInfo.cmake

@@ -76,6 +76,9 @@ if(BUILD_GUI)
     if(BUILD_ONLINE_HELP)
         message(STATUS "QHELPGENERATOR =        ${QHELPGENERATOR}")
     endif()
+    if(MSVC)
+        message(STATUS "WINDEPLOYQT =           ${WINDEPLOYQT}")
+    endif()
 endif()
 message(STATUS)
 message(STATUS "HAVE_RULES =            ${HAVE_RULES}")

gui/CMakeLists.txt

@@ -71,6 +71,12 @@ CheckOptions:
         add_dependencies(cppcheck-gui online-help.qhc)
     endif()
 
+    if(MSVC)
+        message(STATUS "CMAKE_BINARY_DIR=${CMAKE_BINARY_DIR}")
+        add_custom_target(windeployqt ${WINDEPLOYQT} --no-translations ${CMAKE_BINARY_DIR})
+        add_dependencies(windeployqt cppcheck-gui)
+    endif()
+
     install(TARGETS cppcheck-gui RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT applications)
     install(FILES ${qms} DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT applications)