Skip to content

Commit e127157

Browse files
committed
CI-windows.yml: cleaned and sped up build_qt job
1 parent 32dcc39 commit e127157

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

.github/workflows/CI-windows.yml

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ defaults:
2121

2222
jobs:
2323

24-
# TODO: use Debug build to speed it up?
2524
build_qt:
2625
strategy:
2726
matrix:
@@ -52,13 +51,13 @@ jobs:
5251
- name: Run CMake
5352
run: |
5453
rem TODO: enable rules?
55-
rem specify Release build so matchcompiler is used
56-
cmake -S . -B build -Werror=dev --warn-uninitialized -DCMAKE_BUILD_TYPE=Release -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DBUILD_TESTING=Off -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DBUILD_ONLINE_HELP=On -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
54+
cmake -S . -B build -Werror=dev --warn-uninitialized -DCMAKE_BUILD_TYPE=Debug -DCMAKE_COMPILE_WARNING_AS_ERROR=On -DBUILD_TESTING=Off -DBUILD_GUI=On -DWITH_QCHART=On -DBUILD_TRIAGE=On -DBUILD_ONLINE_HELP=On -DCMAKE_INSTALL_PREFIX=cppcheck-cmake-install -DCMAKE_COMPILE_WARNING_AS_ERROR=On || exit /b !errorlevel!
5755
5856
- name: Build GUI release
5957
run: |
60-
cmake --build build --target cppcheck-gui --config Release || exit /b !errorlevel!
58+
cmake --build build --config Debug --target cppcheck-gui || exit /b !errorlevel!
6159
60+
# TODO: can this be done in CMake?
6261
- name: Deploy GUI
6362
run: |
6463
windeployqt build\bin\Release || exit /b !errorlevel!
@@ -69,7 +68,7 @@ jobs:
6968

7069
- name: Run CMake install
7170
run: |
72-
rem TODO: this performs a Debug build
73-
rem TODO: the Qt DLLS are not being installed (because of the missing windeployqt?)
74-
cmake --build build --target install
71+
rem TODO: the Qt DLLs are not being installed
72+
cmake --build build --config Debug --target install
7573
rem TODO: validate the installed files
74+
rem TODO: the structure does not match an actual Windows installation

0 commit comments

Comments
 (0)