Cleanup changes to CDS extractor

Applies suggestions from Copilot review of PR advanced-security#203 for the
`advanced-security/codeql-sap-js` repo.

Author: data-douser

extractors/cds/tools/dist/cds-extractor.bundle.js

@@ -311,7 +311,7 @@ function testCdsCommand(
       {
         encoding: 'utf8',
         stdio: 'pipe',
-        timeout: 10000, // timeout after 10 seconds
+        timeout: DEFAULT_COMMAND_TIMEOUT_MS, // timeout after 10 seconds
         cwd: sourceRoot,
         env: cleanEnv,
       },

extractors/cds/tools/dist/cds-extractor.bundle.js.map

@@ -94,7 +94,7 @@ describe('diagnostics', () => {
   describe('addJavaScriptExtractorDiagnostic', () => {
     it('should add JavaScript extractor diagnostic successfully', () => {
       const filePath = '/path/to/source/root';
-      const errorMessage = 'Message: JavaScript extracutor failed';
+      const errorMessage = 'Message: JavaScript extractor failed';
       const codeqlExePath = '/path/to/codeql';
 
       // Mock process.env to include necessary environment variable

extractors/cds/tools/src/cds/compiler/command.ts

@@ -4,7 +4,7 @@ const fs = require('fs');
 const os = require('os');
 const path = require('path');
 
-const DEFAULT_TIMEOUT_MS = 5000; // Default timeout for execution in milliseconds
+const CMD_TIMEOUT_MS = 5000; // Default timeout for execution in milliseconds
 const MAX_BUNDLE_SIZE_MB = 0.5; // We expect the bundle to be quite small
 
 const bundlePath = path.join(__dirname, 'dist', 'cds-extractor.bundle.js');
@@ -45,22 +45,19 @@ try {
     fs.mkdirSync(testDir, { recursive: true });
   }
 
-  // Test with a timeout to avoid hanging
-  // We expect this to fail or timeout since we're not providing proper arguments
-  // but it should at least start execution
-  const nodeCmd = `node "${bundlePath}" "${testDir}"`;
-
+  // Test with a timeout to avoid hanging. We expect this to fail or timeout since
+  // we are not providing proper arguments but it should at least start execution.
   try {
-    execSync(nodeCmd, {
+    execSync(`node "${bundlePath}" "${testDir}"`, {
       stdio: 'pipe',
       cwd: testDir,
-      timeout: DEFAULT_TIMEOUT_MS,
+      timeout: CMD_TIMEOUT_MS,
       encoding: 'utf8',
     });
     console.log('✅ Bundle execution completed successfully');
   } catch (error) {
     // We expect this to fail or timeout in test environment
-    if (error.code === 'TIMEOUT' || error.signal === 'SIGTERM') {
+    if (error.killed) {
       console.log('✅ Bundle execution test passed (timed out as expected)');
     } else if (error.status !== 0) {
       // Check if it's a controlled exit (expected behavior)