You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Contributing to Eclipse Mraa (libmraa) {#contributing}
2
2
======================
3
3
4
-
Eclipse Mraa is an opensource project and we are actively looking for people to help
4
+
Eclipse Mraa is an open source project and we are actively looking for people to help
5
5
with:
6
6
7
7
- Writing platform supports for all types of boards running linux
@@ -16,7 +16,6 @@ issue first so we can avoid disappointments come merging time!
16
16
Basic rules
17
17
-----------
18
18
- Your code must build
19
-
- Commits must have a sign-off line by at least yourself
20
19
- Commits must be named <file/module>: Some decent description
21
20
- Try not to break master. In any commit.
22
21
- Try to split commits up logically, you will be asked to rebase them if they
@@ -28,13 +27,13 @@ Coding Style
28
27
------------
29
28
30
29
Coding style for all code is defined by clang-format, have a look at it. Avoid
31
-
styling fixes as they make history difficult to read. Javascript & Java can
30
+
styling fixes as they make history difficult to read. JavaScript & Java can
32
31
also be parsed through the clang-format, it complains but seems to do an ok
33
32
job. Few exceptions to coding styles:
34
-
- All python code is indented by 2 spaces
35
-
-CmakeLists files are 2 space indented and a space is required before all
36
-
brackets so endif () and if () and command (). Also use lowercase for
37
-
everything but variables. Cmake is case insensitive but this isn't the wild
33
+
- All Python code is indented by 2 spaces
34
+
-CMakeLists files are 2 space indented and a space is required before all
35
+
brackets so `endif ()` and `if ()` and `command ()`. Also use lowercase for
36
+
everything but variables. CMake is case insensitive but this isn't the wild
38
37
wild west ;-)
39
38
40
39
Use common sense and don't be afraid to challenge something if it doesn't make sense!
@@ -43,7 +42,7 @@ Author Rules
43
42
------------
44
43
45
44
If you create a file, then add yourself as the Author at the top. If you did a
46
-
large contribution to it (or if you want to ;-)), then fee free to add yourself
45
+
large contribution to it (or if you want to ;-)), then feel free to add yourself
47
46
to the contributors list in that file. You can also add your own copyright
48
47
statement to the file but cannot add a license of your own. If you're borrowing
49
48
code that comes from a project with another license, make sure to explicitly
@@ -52,25 +51,23 @@ note this in your PR.
52
51
Eclipse Contributor Agreement
53
52
------------
54
53
55
-
Your contribution cannot be accepted unless you have a signed [ECA - Eclipse Foundation Contributor Agreement](http://www.eclipse.org/legal/ECA.php) in place.
54
+
Your contribution cannot be accepted unless you have a signed [ECA - Eclipse Foundation Contributor Agreement](https://www.eclipse.org/legal/eca/) in place.
56
55
57
56
Here is the checklist for contributions to be _acceptable_:
58
57
59
-
1.[Create an account at Eclipse](https://dev.eclipse.org/site_login/createaccount.php).
58
+
1.[Create an account at Eclipse](https://accounts.eclipse.org/user/register).
60
59
2. Add your GitHub user name in your account settings.
61
-
3.[Log into the project's portal](https://projects.eclipse.org/) and sign the ["Eclipse ECA"](https://projects.eclipse.org/user/sign/cla).
62
-
4. Ensure that you [_sign-off_](https://wiki.eclipse.org/Development_Resources/Contributing_via_Git#Signing_off_on_a_commit) your Git commits.
60
+
3.[Log in to the projects forge](https://www.eclipse.org/contribute/cla/) and sign the ["Eclipse ECA"](https://accounts.eclipse.org/user/eca).
63
61
5. Ensure that you use the _same_ email address as your Eclipse account in commits.
64
62
6. Include the appropriate copyright notice and license at the top of each file.
65
63
66
-
Your signing of the ECA will be verified by a webservice called 'ip-validation'
67
-
that checks the email address that signed-off on your commits has signed the
64
+
Your signing of the ECA will be verified by a Github Check called 'eclipsefdn/eca'
65
+
that checks the email address that authored your commits has signed the
68
66
ECA. **Note**: This service is case-sensitive, so ensure the email that signed
69
-
the ECA and that signed-off on your commits is the same, down to the case.
67
+
the ECA and that authored your commits is the same, down to the case.
70
68
71
69
Where to find us
72
70
----------------
73
71
74
72
Hop onto the freenode network on IRC and join #mraa. Please be patient as we're
0 commit comments