Skip to content

Commit ee6e65a

Browse files
alext-mkrstingleby
authored andcommitted
mock: use MRAA_PIN_NAME_SIZE for strncpy to avoid truncation
This fixes the following compilation warnings: mraa/src/src/mock/mock_board.c: In function ‘mraa_mock_board’: mraa/src/src/mock/mock_board.c:156:5: warning: ‘strncpy’ output truncated before terminating nul copying 8 bytes from a string of the same length [-Wstringop-truncation] 156 | strncpy(b->pins[pos].name, "SPI0MOSI", 8); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mraa/src/src/mock/mock_board.c:162:5: warning: ‘strncpy’ output truncated before terminating nul copying 8 bytes from a string of the same length [-Wstringop-truncation] 162 | strncpy(b->pins[pos].name, "SPI0MISO", 8); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ mraa/src/src/mock/mock_board.c:168:5: warning: ‘strncpy’ output truncated before terminating nul copying 8 bytes from a string of the same length [-Wstringop-truncation] 168 | strncpy(b->pins[pos].name, "SPI0SCLK", 8); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Alex T <alext.mkrs@gmail.com>
1 parent 9d4319d commit ee6e65a

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/mock/mock_board.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -123,62 +123,62 @@ mraa_mock_board()
123123
// Pin definitions
124124
int pos = 0;
125125

126-
strncpy(b->pins[pos].name, "GPIO0", 8);
126+
strncpy(b->pins[pos].name, "GPIO0", MRAA_PIN_NAME_SIZE);
127127
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 1, 0, 0, 0, 0, 0, 0 };
128128
b->pins[pos].gpio.pinmap = 0;
129129
b->pins[pos].gpio.mux_total = 0;
130130
pos++;
131131

132-
strncpy(b->pins[pos].name, "ADC0", 8);
132+
strncpy(b->pins[pos].name, "ADC0", MRAA_PIN_NAME_SIZE);
133133
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 0, 0, 0, 0, 0, 1, 0 };
134134
b->pins[pos].aio.pinmap = 0;
135135
b->pins[pos].aio.mux_total = 0;
136136
pos++;
137137

138-
strncpy(b->pins[pos].name, "I2C0SDA", 8);
138+
strncpy(b->pins[pos].name, "I2C0SDA", MRAA_PIN_NAME_SIZE);
139139
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 0, 0, 0, 0, 1, 0, 0 };
140140
b->pins[pos].i2c.mux_total = 0;
141141
b->pins[pos].i2c.pinmap = 0;
142142
pos++;
143143

144-
strncpy(b->pins[pos].name, "I2C0SCL", 8);
144+
strncpy(b->pins[pos].name, "I2C0SCL", MRAA_PIN_NAME_SIZE);
145145
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 0, 0, 0, 0, 1, 0, 0 };
146146
b->pins[pos].i2c.mux_total = 0;
147147
b->pins[pos].i2c.pinmap = 0;
148148
pos++;
149149

150-
strncpy(b->pins[pos].name, "SPI0CS", 8);
150+
strncpy(b->pins[pos].name, "SPI0CS", MRAA_PIN_NAME_SIZE);
151151
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 0, 0, 0, 1, 0, 0, 0 };
152152
b->pins[pos].spi.mux_total = 0;
153153
b->pins[pos].spi.pinmap = 0;
154154
pos++;
155155

156-
strncpy(b->pins[pos].name, "SPI0MOSI", 8);
156+
strncpy(b->pins[pos].name, "SPI0MOSI", MRAA_PIN_NAME_SIZE);
157157
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 0, 0, 0, 1, 0, 0, 0 };
158158
b->pins[pos].spi.mux_total = 0;
159159
b->pins[pos].spi.pinmap = 0;
160160
pos++;
161161

162-
strncpy(b->pins[pos].name, "SPI0MISO", 8);
162+
strncpy(b->pins[pos].name, "SPI0MISO", MRAA_PIN_NAME_SIZE);
163163
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 0, 0, 0, 1, 0, 0, 0 };
164164
b->pins[pos].spi.mux_total = 0;
165165
b->pins[pos].spi.pinmap = 0;
166166
pos++;
167167

168-
strncpy(b->pins[pos].name, "SPI0SCLK", 8);
168+
strncpy(b->pins[pos].name, "SPI0SCLK", MRAA_PIN_NAME_SIZE);
169169
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 0, 0, 0, 1, 0, 0, 0 };
170170
b->pins[pos].spi.mux_total = 0;
171171
b->pins[pos].spi.pinmap = 0;
172172
pos++;
173173

174-
strncpy(b->pins[pos].name, "UART0RX", 8);
174+
strncpy(b->pins[pos].name, "UART0RX", MRAA_PIN_NAME_SIZE);
175175
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 0, 0, 0, 0, 0, 0, 1 };
176176
b->pins[pos].uart.pinmap = 0;
177177
b->pins[pos].uart.parent_id = 0;
178178
b->pins[pos].uart.mux_total = 0;
179179
pos++;
180180

181-
strncpy(b->pins[pos].name, "UART0TX", 8);
181+
strncpy(b->pins[pos].name, "UART0TX", MRAA_PIN_NAME_SIZE);
182182
b->pins[pos].capabilities = (mraa_pincapabilities_t){ 1, 0, 0, 0, 0, 0, 0, 1 };
183183
b->pins[pos].uart.pinmap = 0;
184184
b->pins[pos].uart.parent_id = 0;

0 commit comments

Comments
 (0)