Apply suggestions from code review

geoffw0 · paldepind · web-flow · commit 1e64f50c3c77 · 2025-05-27T08:51:00.000+01:00
Co-authored-by: Simon Friis Vindum &lt;paldepind@github.com&gt;
diff --git a/rust/ql/lib/codeql/rust/elements/DerefExpr.qll b/rust/ql/lib/codeql/rust/elements/DerefExpr.qll
@@ -6,7 +6,7 @@ private import codeql.rust.elements.PrefixExpr
 private import codeql.rust.elements.Operation
 
 /**
- * A dereference expression, `*`.
+ * A dereference expression, the prefix operator `*`.
  */
 final class DerefExpr extends PrefixExpr, Operation {
   DerefExpr() { this.getOperatorName() = "*" }
diff --git a/rust/ql/lib/codeql/rust/security/AccessInvalidPointerExtensions.qll b/rust/ql/lib/codeql/rust/security/AccessInvalidPointerExtensions.qll
@@ -50,7 +50,7 @@ module AccessInvalidPointer {
    * A pointer access using the unary `*` operator.
    */
   private class DereferenceSink extends Sink {
-    DereferenceSink() { exists(DerefExpr p | p.getExpr() = this.asExpr().getExpr()) }
+    DereferenceSink() { any(DerefExpr p).getExpr() = this.asExpr().getExpr() }
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ module AccessInvalidPointer {`
`50`	`50`	* A pointer access using the unary `*` operator.
`51`	`51`	`*/`
`52`	`52`	`private class DereferenceSink extends Sink {`
`53`		`- DereferenceSink() { exists(DerefExpr p \| p.getExpr() = this.asExpr().getExpr()) }`
	`53`	`+ DereferenceSink() { any(DerefExpr p).getExpr() = this.asExpr().getExpr() }`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`/**`