Python: Fix all metrics-related compilation failures

In hindsight, having a `.getMetrics()` method that just returns `this`
is somewhat weird. It's possibly that it predates the existence of the
inline cast, however.

Author: tausbn

python/ql/src/Functions/OverlyComplexDelMethod.ql

@@ -18,6 +18,6 @@ from FunctionValue method
 where
   exists(ClassValue c |
     c.declaredAttribute("__del__") = method and
-    method.getScope().getMetrics().getCyclomaticComplexity() > 3
+    method.getScope().(FunctionMetrics).getCyclomaticComplexity() > 3
   )
 select method, "Overly complex '__del__' method."

python/ql/src/Metrics/CLinesOfCode.ql

@@ -10,6 +10,7 @@
  */
 
 import python
+private import LegacyPointsTo
 
-from Function f
-select f, f.getMetrics().getNumberOfLinesOfCode() as n order by n desc
+from FunctionMetrics f
+select f, f.getNumberOfLinesOfCode() as n order by n desc

python/ql/src/Metrics/ClassAfferentCoupling.ql

@@ -11,6 +11,7 @@
  */
 
 import python
+private import LegacyPointsTo
 
 from ClassMetrics cls
 select cls, cls.getAfferentCoupling() as n order by n desc

python/ql/src/Metrics/ClassEfferentCoupling.ql

@@ -11,6 +11,7 @@
  */
 
 import python
+private import LegacyPointsTo
 
 from ClassMetrics cls
 select cls, cls.getEfferentCoupling() as n order by n desc

python/ql/src/Metrics/CommentRatio.ql

@@ -12,8 +12,10 @@
  */
 
 import python
+private import LegacyPointsTo
 
-from Module m, ModuleMetrics mm
-where mm = m.getMetrics() and mm.getNumberOfLines() > 0
-select m, 100.0 * (mm.getNumberOfLinesOfComments().(float) / mm.getNumberOfLines().(float)) as ratio
+from ModuleMetrics mm
+where mm.getNumberOfLines() > 0
+select mm,
+  100.0 * (mm.getNumberOfLinesOfComments().(float) / mm.getNumberOfLines().(float)) as ratio
   order by ratio desc

python/ql/src/Metrics/CyclomaticComplexity.ql

@@ -13,7 +13,8 @@
  */
 
 import python
+private import LegacyPointsTo
 
-from Function func, int complexity
-where complexity = func.getMetrics().getCyclomaticComplexity()
+from FunctionMetrics func, int complexity
+where complexity = func.getCyclomaticComplexity()
 select func, complexity order by complexity desc

python/ql/src/Metrics/DocStringRatio.ql

@@ -11,9 +11,10 @@
  */
 
 import python
+private import LegacyPointsTo
 
-from Module m, ModuleMetrics mm
-where mm = m.getMetrics() and mm.getNumberOfLines() > 0
-select m,
+from ModuleMetrics mm
+where mm.getNumberOfLines() > 0
+select mm,
   100.0 * (mm.getNumberOfLinesOfDocStrings().(float) / mm.getNumberOfLines().(float)) as ratio
   order by ratio desc

python/ql/src/Metrics/FLines.ql

@@ -9,7 +9,8 @@
  */
 
 import python
+private import LegacyPointsTo
 
-from Module m, int n
-where n = m.getMetrics().getNumberOfLines()
+from ModuleMetrics m, int n
+where n = m.getNumberOfLines()
 select m, n order by n desc

python/ql/src/Metrics/FLinesOfCode.ql

@@ -11,7 +11,8 @@
  */
 
 import python
+private import LegacyPointsTo
 
-from Module m, int n
-where n = m.getMetrics().getNumberOfLinesOfCode()
+from ModuleMetrics m, int n
+where n = m.getNumberOfLinesOfCode()
 select m, n order by n desc

python/ql/src/Metrics/FLinesOfComments.ql

@@ -10,8 +10,8 @@
  */
 
 import python
+private import LegacyPointsTo
 
-from Module m, int n
-where
-  n = m.getMetrics().getNumberOfLinesOfComments() + m.getMetrics().getNumberOfLinesOfDocStrings()
+from ModuleMetrics m, int n
+where n = m.getNumberOfLinesOfComments() + m.getNumberOfLinesOfDocStrings()
 select m, n order by n desc