Skip to content

Fix securtiy finding - 228370 - #46

Open
v-lzabala wants to merge 5 commits into
mainfrom
vlzabala/fix-security-finding
Open

v-lzabala wants to merge 5 commits into
mainfrom
vlzabala/fix-security-finding

Conversation

@v-lzabala

@v-lzabala v-lzabala commented Nov 13, 2026 •

Copy link
Copy Markdown

Problem

Security Findings created the issue

https://github.com/github/vuln-mgmt/issues/228370

Fix

  • Restricts privileged deployments to verified main commits, preventing execution of untrusted PR code.
  • Runs PR validation separately with read-only permissions and no deployment secrets.
  • Uses a separate privileged workflow to validate results and post comments without executing PR code.

@github-actions

Copy link
Copy Markdown

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down deployment summary listed below:

  1. ✔️ Obtain an approval/review on this pull request

  2. ✔️ Wait for PR validation against the local LDAP fixture

    PR branches cannot be deployed before merge. Authorized users can redeploy trusted main with .deploy main.

  3. 🎉 Merge to main to deploy the reviewed changes!

Comment thread .github/workflows/pr-results.yml Resolved
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@v-lzabala
v-lzabala marked this pull request as ready for review November 17, 2026 15:32
Copilot AI adaptive review requested due to automatic review settings November 17, 2026 15:32

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Approval is blocked by an unpinned privileged third-party action and a pull-request-controlled validation workflow that can produce a false passing result.

2 open issues
What changed in this PR

This PR replaces pre-merge branch deployments with read-only pull request validation, restricts IssueOps deployments to the current trusted main commit, and adds validation-result reporting.

Changes:

  • Adds local LDAP-based PR validation and artifact-backed result comments.
  • Restricts branch deployments to trusted main commits and verifies checkout integrity.
  • Updates workflow runners, documentation, and contributor deployment instructions.
File Description
README.md Documents pull request validation, trusted-main deployment behavior, and updated deployment guidance.
.github/​workflows/​pr-validation.yml Runs read-only pull request validation against the local LDAP fixture and uploads the pull request identifier artifact.
.github/​workflows/​pr-results.yml Validates pull request artifacts and posts successful validation comments for eligible pull requests.
.github/​workflows/​manager.yml Updates the manager workflow runner configuration.
.github/​workflows/​checksum.yml Updates the checksum workflow runner configuration.
.github/​workflows/​branch-deploy.yml Restricts IssueOps deployments to the current trusted main commit and verifies checkout integrity.
.github/​new-pr-comment.md Updates contributor instructions for the new validation and deployment flow.

Review effort: Lite (adaptive)

Comment thread .github/workflows/branch-deploy.yml Resolved
Comment thread .github/workflows/pr-validation.yml Resolved
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
@v-lzabala v-lzabala changed the title Test securtiy finding Fix securtiy finding - 228370 Nov 17, 2026
@rick

rick commented Nov 17, 2026

Copy link
Copy Markdown

👎

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants