[Code Quality] Split compiler_pre_activation_job.go (956 lines) into focused build/helpers files

[github-actions]

Description

compiler_pre_activation_job.go at 956 lines exceeds the 800-line guideline and contains 40 functions covering distinct concerns (job building, condition guards, permissions, step generation). Splitting it into focused files improves navigability and sets a clearer boundary for future tests.

Suggested Changes

• Split pkg/workflow/compiler_pre_activation_job.go at the build/helper boundary:
  • compiler_pre_activation_job_build.go — core job builder functions (buildPreActivationJob, job wiring)
  • compiler_pre_activation_job_helpers.go — smaller helpers (step generation, permissions, guards)
• No logic changes — pure mechanical extraction
• Ensure all existing tests still pass after the split

Files Affected

• pkg/workflow/compiler_pre_activation_job.go (to be split into two files)
• pkg/workflow/compiler_pre_activation_job_build.go (new file)
• pkg/workflow/compiler_pre_activation_job_helpers.go (new file)

Success Criteria

• Both new files are < 600 lines each
• Zero logic changes (diff is purely file movement)
• make test-unit passes with no regressions
• make golint-custom shows no new findings

Source

Extracted from Daily Compiler Code Quality Report - 2026-07-27. Priority 3: Split compiler_pre_activation_job.go at the build/helper boundary into two focused files.

Priority

Low — Mechanical split, no logic changes. Estimated effort: 1–2 hours.

🔍 Task mining by Discussion Task Miner - Code Quality Improvement Agent · sonnet46 · 55.3 AIC · ⌖ 5.38 AIC · ⊞ 7.2K · ◷

• expires on Jul 28, 2026, 5:42 AM UTC-08:00

[github-actions]

This issue was automatically closed because it expired on 2026-07-28T13:42:40.625Z.

Closed by Workflow