Fix Proxmox VE sensor crashes due to missing API fields

Update all sensor definitions (Node, VM, Container, and Storage) to
safely handle missing keys in the Proxmox API response by using
dict.get(). This prevents KeyError crashes for entities where
certain fields (like used_fraction, cpu, or memory) may be omitted.

Added tests/components/proxmoxve/test_sensor_missing_data.py to
verify robust handling of incomplete API data.

Author: irishpadres

homeassistant/components/proxmoxve/binary_sensor.py

@@ -39,43 +39,48 @@ class ProxmoxContainerBinarySensorEntityDescription(BinarySensorEntityDescriptio
     """Class to hold Proxmox container binary sensor description."""
 
     state_fn: Callable[[dict[str, Any]], bool | None]
+    exists_fn: Callable[[dict[str, Any]], bool] = lambda _: True
 
 
 @dataclass(frozen=True, kw_only=True)
 class ProxmoxVMBinarySensorEntityDescription(BinarySensorEntityDescription):
     """Class to hold Proxmox endpoint binary sensor description."""
 
     state_fn: Callable[[dict[str, Any]], bool | None]
+    exists_fn: Callable[[dict[str, Any]], bool] = lambda _: True
 
 
 @dataclass(frozen=True, kw_only=True)
 class ProxmoxNodeBinarySensorEntityDescription(BinarySensorEntityDescription):
     """Class to hold Proxmox node binary sensor description."""
 
     state_fn: Callable[[ProxmoxNodeData], bool | None]
+    exists_fn: Callable[[ProxmoxNodeData], bool] = lambda _: True
 
 
 @dataclass(frozen=True, kw_only=True)
 class ProxmoxStorageBinarySensorEntityDescription(BinarySensorEntityDescription):
     """Class to hold Proxmox storage binary sensor description."""
 
     state_fn: Callable[[dict[str, Any]], bool | None]
+    exists_fn: Callable[[dict[str, Any]], bool] = lambda _: True
 
 
 NODE_SENSORS: tuple[ProxmoxNodeBinarySensorEntityDescription, ...] = (
     ProxmoxNodeBinarySensorEntityDescription(
         key="status",
         translation_key="status",
-        state_fn=lambda data: data.node["status"] == NODE_ONLINE,
+        state_fn=lambda data: data.node.get("status") == NODE_ONLINE,
         device_class=BinarySensorDeviceClass.RUNNING,
         entity_category=EntityCategory.DIAGNOSTIC,
     ),
     ProxmoxNodeBinarySensorEntityDescription(
         key="node_backup_status",
         translation_key="node_backup_status",
         state_fn=lambda data: bool(
-            data.backups and data.backups[0]["status"] != STATUS_OK
+            data.backups and data.backups[0].get("status") != STATUS_OK
         ),
+        exists_fn=lambda data: bool(data.backups),
         device_class=BinarySensorDeviceClass.PROBLEM,
         entity_category=EntityCategory.DIAGNOSTIC,
     ),
@@ -85,7 +90,7 @@ class ProxmoxStorageBinarySensorEntityDescription(BinarySensorEntityDescription)
     ProxmoxContainerBinarySensorEntityDescription(
         key="status",
         translation_key="status",
-        state_fn=lambda data: data["status"] == VM_CONTAINER_RUNNING,
+        state_fn=lambda data: data.get("status") == VM_CONTAINER_RUNNING,
         device_class=BinarySensorDeviceClass.RUNNING,
         entity_category=EntityCategory.DIAGNOSTIC,
     ),
@@ -95,7 +100,7 @@ class ProxmoxStorageBinarySensorEntityDescription(BinarySensorEntityDescription)
     ProxmoxVMBinarySensorEntityDescription(
         key="status",
         translation_key="status",
-        state_fn=lambda data: data["status"] == VM_CONTAINER_RUNNING,
+        state_fn=lambda data: data.get("status") == VM_CONTAINER_RUNNING,
         device_class=BinarySensorDeviceClass.RUNNING,
         entity_category=EntityCategory.DIAGNOSTIC,
     ),
@@ -105,19 +110,22 @@ class ProxmoxStorageBinarySensorEntityDescription(BinarySensorEntityDescription)
     ProxmoxStorageBinarySensorEntityDescription(
         key="storage_active",
         translation_key="storage_active",
-        state_fn=lambda data: data["active"] == STORAGE_ACTIVE,
+        state_fn=lambda data: data.get("active") == STORAGE_ACTIVE,
+        exists_fn=lambda data: "active" in data,
         entity_category=EntityCategory.DIAGNOSTIC,
     ),
     ProxmoxStorageBinarySensorEntityDescription(
         key="storage_enabled",
         translation_key="storage_enabled",
-        state_fn=lambda data: data["enabled"] == STORAGE_ENABLED,
+        state_fn=lambda data: data.get("enabled") == STORAGE_ENABLED,
+        exists_fn=lambda data: "enabled" in data,
         entity_category=EntityCategory.DIAGNOSTIC,
     ),
     ProxmoxStorageBinarySensorEntityDescription(
         key="storage_shared",
         translation_key="storage_shared",
-        state_fn=lambda data: data["shared"] == STORAGE_SHARED,
+        state_fn=lambda data: data.get("shared") == STORAGE_SHARED,
+        exists_fn=lambda data: "shared" in data,
         entity_category=EntityCategory.DIAGNOSTIC,
     ),
 )
@@ -137,6 +145,7 @@ def _async_add_new_nodes(nodes: list[ProxmoxNodeData]) -> None:
             ProxmoxNodeBinarySensor(coordinator, entity_description, node)
             for node in nodes
             for entity_description in NODE_SENSORS
+            if entity_description.exists_fn(node)
         )
 
     def _async_add_new_vms(
@@ -147,6 +156,7 @@ def _async_add_new_vms(
             ProxmoxVMBinarySensor(coordinator, entity_description, vm, node_data)
             for (node_data, vm) in vms
             for entity_description in VM_SENSORS
+            if entity_description.exists_fn(vm)
         )
 
     def _async_add_new_containers(
@@ -159,6 +169,7 @@ def _async_add_new_containers(
             )
             for (node_data, container) in containers
             for entity_description in CONTAINER_SENSORS
+            if entity_description.exists_fn(container)
         )
 
     def _async_add_new_storages(
@@ -171,6 +182,7 @@ def _async_add_new_storages(
             )
             for (node_data, storage) in storages
             for entity_description in STORAGE_SENSORS
+            if entity_description.exists_fn(storage)
         )
 
     coordinator.new_nodes_callbacks.append(_async_add_new_nodes)