From 6489c9c1a94c69048f3b621c2e0cd4b5e766e70a Mon Sep 17 00:00:00 2001 From: Michael Nahkies Date: Sun, 12 Jul 2026 13:16:55 +0100 Subject: [PATCH 1/2] test: add failing test for --- src/test-suite/tests/comment.json | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 src/test-suite/tests/comment.json diff --git a/src/test-suite/tests/comment.json b/src/test-suite/tests/comment.json new file mode 100644 index 0000000..6020808 --- /dev/null +++ b/src/test-suite/tests/comment.json @@ -0,0 +1,17 @@ +{ + "$schema": "../test-suite.schema.json", + + "description": "The comment keyword is ignored", + "tests": [ + { + "description": "format", + "schema": { + "$comment":"this is a comment", + "type":"object" + }, + "instance": {}, + "errors": [ + ] + } + ] +} From bb379031831f201d1a6e8b7846025dd3eb375694 Mon Sep 17 00:00:00 2001 From: Michael Nahkies Date: Sun, 12 Jul 2026 13:18:10 +0100 Subject: [PATCH 2/2] feat: register normalization handler for comment --- src/index.js | 2 ++ src/normalization-handlers/comment.js | 11 +++++++++++ 2 files changed, 13 insertions(+) create mode 100644 src/normalization-handlers/comment.js diff --git a/src/index.js b/src/index.js index 92f9db0..0527cfe 100644 --- a/src/index.js +++ b/src/index.js @@ -5,6 +5,7 @@ import additionalItemsNormalizationHandler from "./normalization-handlers/draft- import additionalPropertiesNormalizationHandler from "./normalization-handlers/additionalProperties.js"; import allOfNormalizationHandler from "./normalization-handlers/allOf.js"; import anyOfNormalizationHandler from "./normalization-handlers/anyOf.js"; +import commentNormalizationHandler from "./normalization-handlers/comment.js"; import constNormalizationHandler from "./normalization-handlers/const.js"; import containsNormalizationHandler from "./normalization-handlers/contains.js"; import containsDraft06NormalizationHandler from "./normalization-handlers/draft-06/contains.js"; @@ -86,6 +87,7 @@ setNormalizationHandler("https://json-schema.org/keyword/draft-04/additionalItem setNormalizationHandler("https://json-schema.org/keyword/additionalProperties", additionalPropertiesNormalizationHandler); setNormalizationHandler("https://json-schema.org/keyword/allOf", allOfNormalizationHandler); setNormalizationHandler("https://json-schema.org/keyword/anyOf", anyOfNormalizationHandler); +setNormalizationHandler("https://json-schema.org/keyword/comment", commentNormalizationHandler); setNormalizationHandler("https://json-schema.org/keyword/const", constNormalizationHandler); setNormalizationHandler("https://json-schema.org/keyword/contains", containsNormalizationHandler); setNormalizationHandler("https://json-schema.org/keyword/draft-06/contains", containsDraft06NormalizationHandler); diff --git a/src/normalization-handlers/comment.js b/src/normalization-handlers/comment.js new file mode 100644 index 0000000..09b8360 --- /dev/null +++ b/src/normalization-handlers/comment.js @@ -0,0 +1,11 @@ +/** + * @import { NormalizationHandler } from "../index.d.ts" + */ + +/** @type NormalizationHandler */ +const commentNormalizationHandler = { + evaluate() { + } +}; + +export default commentNormalizationHandler;